Skip to content

chore(actions): check to install jq if it is not already #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025

Conversation

appleboy
Copy link
Contributor

@appleboy appleboy commented Mar 28, 2025

  • Change single quotes to double quotes for consistency
  • Add a check to install jq if it is not already installed

Description:

image

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

- Change single quotes to double quotes for consistency
- Add a check to install `jq` if it is not already installed

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy requested a review from a team as a code owner March 28, 2025 01:09
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2025

CLA assistant check
All committers have signed the CLA.

@appleboy
Copy link
Contributor Author

@abmussani @nabeelalam any feedback?

@nabeelalam
Copy link
Contributor

Hi @appleboy, thanks for creating this PR. I just gave the change a quick look and it looks more robust, will take a thorough look as well.
Could you add a bit more description about the steps that led you to encounter the error in that screenshot?

@appleboy
Copy link
Contributor Author

@nabeelalam Not all CI environments have the jq command pre-installed on their default OS. Our team discovered this issue while using Gitea + Actions. The OS we are using is a custom-developed version based on Ubuntu.

@nabeelalam
Copy link
Contributor

@appleboy These updates look good. Thanks! ✅
action.yml has been updated since the last commit, so just need to resolve conflicts.

@appleboy
Copy link
Contributor Author

@nabeelalam Done. Thanks for your review.

Copy link
Contributor

@nabeelalam nabeelalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabeelalam nabeelalam merged commit f3b7c13 into trufflesecurity:main Jun 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants