-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(actions): check to install jq
if it is not already
#4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change single quotes to double quotes for consistency - Add a check to install `jq` if it is not already installed Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@abmussani @nabeelalam any feedback? |
Hi @appleboy, thanks for creating this PR. I just gave the change a quick look and it looks more robust, will take a thorough look as well. |
@nabeelalam Not all CI environments have the jq command pre-installed on their default OS. Our team discovered this issue while using Gitea + Actions. The OS we are using is a custom-developed version based on Ubuntu. |
@appleboy These updates look good. Thanks! ✅ |
@nabeelalam Done. Thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jq
if it is not already installedDescription:
Checklist:
make test-community
)?make lint
this requires golangci-lint)?