Analyzer/datadog #4132
Merged
Analyzer/datadog #4132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabeelalam
reviewed
May 13, 2025
abmussani
suggested changes
May 16, 2025
- Simplified API key retrieval logic by removing redundant checks for "key". - Enhanced permission binding extraction by introducing a new function for permissions. - Cleaned up resource binding logic for better clarity and maintainability. - Removed unnecessary ID fields from scopes.json to reduce clutter.
x-stp
reviewed
May 24, 2025
| } | ||
|
|
||
| permissionBindings := secretInfoPermissionsToAnalyzerPermission(info.Permissions) | ||
| result.Bindings = analyzers.BindAllPermissions(*userResource, *permissionBindings...) |
Contributor
There was a problem hiding this comment.
what if userId is nil? nil check on L124, though already deref here.
zricethezav
approved these changes
Jun 10, 2025
abmussani
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds analyzer for DataDog
DataDog API docs: Link
Checklist:
make test-community)?make lintthis requires golangci-lint)?