Skip to content

Conversation

@kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented May 12, 2025

Description:

This PR adds a new analyzer for databricks

Tests:

Screenshot from 2025-05-12 13-36-10
Screenshot from 2025-05-12 13-18-55

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested review from a team as code owners May 12, 2025 08:38
Copy link
Contributor

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Left a few non-blocking suggestions and a couple questions.

@kashifkhan0771 kashifkhan0771 force-pushed the feat/oss-166-databricks-analyzer branch from f92280d to 4dba4f7 Compare May 13, 2025 12:12
@kashifkhan0771 kashifkhan0771 force-pushed the feat/oss-166-databricks-analyzer branch from 3029af6 to aa885fa Compare May 16, 2025 06:08
@kashifkhan0771 kashifkhan0771 self-assigned this May 19, 2025
@kashifkhan0771
Copy link
Contributor Author

@abmussani @ahrav Just checking in does this PR look good to you for merge?

@kashifkhan0771 kashifkhan0771 force-pushed the feat/oss-166-databricks-analyzer branch from 2e4a77d to cc1ad82 Compare May 20, 2025 05:43
@kashifkhan0771 kashifkhan0771 merged commit 9a2b268 into trufflesecurity:main May 20, 2025
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the feat/oss-166-databricks-analyzer branch May 20, 2025 05:55
abmussani pushed a commit to bunnyanon/trufflehog that referenced this pull request May 21, 2025
* main: (121 commits)
  Fixed Grafana detector (trufflesecurity#4166)
  Reduce verbosity of chunk trace logging (trufflesecurity#4161)
  Increase postman logging verbosity (trufflesecurity#4160)
  Change github file extension log message verbosity (trufflesecurity#4159)
  docs: fix typos (trufflesecurity#4158)
  fix(twitch): Update Twitch detector to handle new RawV2 field and adjust test expectations (trufflesecurity#4150)
  Add a bunch of Postman logging (trufflesecurity#4154)
  Added DataBricks Analyzer (trufflesecurity#4135)
  fixed shopify detector line number (trufflesecurity#4149)
  chore: run setup-go after checkout (trufflesecurity#4143)
  Add per-chunk detection logging (trufflesecurity#4152)
  [Feat] Added Dropbox API OAuth2 Token Analyzer (trufflesecurity#4080)
  Updated Github Source Validate method (trufflesecurity#4144)
  replace anthropic reference with groq (trufflesecurity#4147)
  [Fix] Line number issue for custom detector (trufflesecurity#3997)
  fix(postman): prevent infinite recursion in variable substitution (trufflesecurity#4145)
  Add metrics to the Postman source (trufflesecurity#4142)
  [Feat] Implementation of Posthog Analyzer (trufflesecurity#4103)
  [Feat] Added Mux API Analyzer (trufflesecurity#4128)
  fixed name of netlify analyzer in cli output (trufflesecurity#4140)
  ...

# Conflicts:
#	pkg/pb/detectorspb/detectors.pb.go
#	proto/detectors.proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants