Skip to content

feat: avoid error when subscription ID is not present #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2025
Merged

feat: avoid error when subscription ID is not present #387

merged 3 commits into from
Jun 28, 2025

Conversation

cheina97
Copy link
Contributor

@cheina97 cheina97 commented Jun 20, 2025 •
edited
Loading

This PR removes the error triggered when a websocket message does not contain a subscription ID.

Check this issue #383

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@cheina97 cheina97 force-pushed the frc/unknownid branch 4 times, most recently from 773f345 to c8db0fe Compare June 23, 2025 08:14
benjaminjkraft
benjaminjkraft reviewed Jun 28, 2025
View reviewed changes
benjaminjkraft
benjaminjkraft approved these changes Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear explanation and tests as well as the fix!

@benjaminjkraft benjaminjkraft merged commit 35bfe03 into Khan:main Jun 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft benjaminjkraft approved these changes

@csilvers csilvers Awaiting requested review from csilvers csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheina97 @benjaminjkraft