bug: characters omitted from airtable

[M0nica]

There's currently a defect where if you input an e-mail like monica+test@gmail.com the + is being omitted in Airtable. The way we are sending data to airtable should be updated to ensure we do not lose special characters from email addresses

Note: This work should fork off of the beta branch.

[afif1400]

Can I work on this?

[M0nica]

Yes @afif1400 this is a high priority issue! If you’re able to work on this soon that would be great. If not, let me know as I may pick it up. Thank you for your interest in contributing.

[M0nica]

I did put in a hot fix to prevent users from submitting e-mail addresses with + signs so when this encoding issue is resolved then #70 should be reverted so that folks can continue submitting e-mail addresses with plus signs.

[afif1400]

Yes @afif1400 this is a high priority issue! If you’re able to work on this soon that would be great. If not, let me know as I may pick it up. Thank you for your interest in contributing.

Sure on it

[afif1400]

There's currently a defect where if you input an e-mail like monica+test@gmail.com the + is being omitted in Airtable. The way we are sending data to airtable should be updated to ensure we do not lose special characters from email addresses

I used the airtable API to send an email address from the register function it does not omit the + character.

• API request URL
  

• table content
  

please, let me know if this is was the bug or from the client-side because the function logic is correct.

[M0nica]

There's currently a defect where if you input an e-mail like monica+test@gmail.com the + is being omitted in Airtable. The way we are sending data to airtable should be updated to ensure we do not lose special characters from email addresses

I used the airtable API to send an email address from the register function it does not omit the + character.

• API request URL
  
• table content
  

please, let me know if this is was the bug or from the client-side because the function logic is correct.

@afif1400 Can you try to reproduce using the same encodeURI function that the client side is using to construct the API URL? Based on what you’re seeing it seems that the the issue may be related to how the client side is passing in the data to the API. https://github.com/react-ladies/React-Ladies/blob/31d7febd2c80a3ee3edfbd8aa87803e5dc7ba901/src/components/Info/Form.js#L18

Note: Depending on your version of the branch you may need to update the RegExp for email validation to allow you to submit a form with a plus sign before the @ symbol.

[afif1400]

There's currently a defect where if you input an e-mail like monica+test@gmail.com the + is being omitted in Airtable. The way we are sending data to airtable should be updated to ensure we do not lose special characters from email addresses

I used the airtable API to send an email address from the register function it does not omit the + character.

• API request URL
  
• table content
  

please, let me know if this is was the bug or from the client-side because the function logic is correct.

@afif1400 Can you try to reproduce using the same encodeURI function that the client side is using to construct the API URL? Based on what you’re seeing it seems that the the issue may be related to how the client side is passing in the data to the API.

https://github.com/react-ladies/React-Ladies/blob/31d7febd2c80a3ee3edfbd8aa87803e5dc7ba901/src/components/Info/Form.js#L18

Note: Depending on your version of the branch you may need to update the RegExp for email validation to allow you to submit a form with a plus sign before the @ symbol.

Yeah... I'll try from the client side.