Updates demos (closes #61) #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <source media="(min-width: 480px) and (max-width: 639px)" | ||
| srcset="http://respimg.cdnconnect.com/basic-implentation/test_landscape_1@2x.jpg"> | ||
| <source media="(min-width: 640px)" | ||
| srcset="http://respimg.cdnconnect.com/basic-implentation/test_landscape_1@4x.jpg"> |
There was a problem hiding this comment.
These aren't art direction, right? So should be srcset with 'x' on img?
There was a problem hiding this comment.
They are... The file names are misleading. We should change that in a followup PR (need to change it at the CDN though, or abandon the CDN)
There was a problem hiding this comment.
OK.
Another thing, I'm not sure it's a good idea to write the media queries like that. What if the viewport is 479.5px? It seems better to only use max-width and move the srcset on the third source to img. The "print" source should probably be placed first so that it can actually be selected.
There was a problem hiding this comment.
This is now done.
marcoscaceres
added a commit
that referenced
this pull request
Sep 8, 2014
Updates demos (closes #61) Merging so we can push this out. We can fix other bugs separately.
|
Nice work! |
|
Awesome, thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yoavweiss and I fixed up the demos to use the modern syntax.