Skip to content

Update picturefill.js from 2.1.0 to 2.3.0 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

seriema
Copy link

@seriema seriema commented Apr 3, 2015

2.3.0 was released 11 days ago, but the responsiveimages.org site was still using 2.1.0 so I thought it was time to update it. Both in regular site and in demos.

Both in regular site and in demos.
@seriema
Copy link
Author

seriema commented Apr 3, 2015

Eh, that failing linthub is complaining about picturefill.js missing semicolons etc. but I didn't write it (obviously). 🐼

@marcoscaceres
Copy link
Contributor

I wouldn't mind just pointing to some CDN for picturefill (latest) instead of hosting it. Is there such an option?

@marcoscaceres
Copy link
Contributor

Ok, should go with this instead.
http://cdnjs.com/libraries/picturefill

@marcoscaceres
Copy link
Contributor

... shame there is no "latest" link... living on the edge is fun.

@marcoscaceres
Copy link
Contributor

Ok, so I'm also inclined to move to the min version. So let's just use:
https://cdnjs.cloudflare.com/ajax/libs/picturefill/2.3.0/picturefill.min.js

@marcoscaceres
Copy link
Contributor

Ok, put together the alt at #71

marcoscaceres pushed a commit that referenced this pull request Apr 8, 2015
Switched to using CDN version of picturefill (closes #70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants