Skip to content

Switched to using CDN version of picturefill (closes #70) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

marcoscaceres
Copy link
Contributor

No description provided.

@marcoscaceres
Copy link
Contributor Author

@seriema can you please check? Or any other lovely person:)

@seriema
Copy link

seriema commented Apr 8, 2015

@marcoscaceres I cloned it locally and checked all the demos. Seems fine, no errors that I could se. 👍

As a sidenote, I do get some things that don't load properly (like CSS on some pages) or some links not working because there seems to be a mix of how links are written. With / or without, causing it to go to root sometimes and sometimes not. Want me to clean that up? =)

@marcoscaceres
Copy link
Contributor Author

Want me to clean that up? =)

Sure! that would be great!

marcoscaceres pushed a commit that referenced this pull request Apr 8, 2015
Switched to using CDN version of picturefill (closes #70)
@marcoscaceres marcoscaceres merged commit c5797e9 into master Apr 8, 2015
@marcoscaceres marcoscaceres deleted the picturefill_cdn branch April 8, 2015 22:17
@coliff
Copy link
Contributor

coliff commented Apr 28, 2015

Would be good to update again to Picturefill 2.3.1. :-)
http://scottjehl.github.io/picturefill/#download

@marcoscaceres
Copy link
Contributor Author

@coliff, done.

@seriema
Copy link

seriema commented Apr 28, 2015

Maybe we can get cdnjs or Picturefill to add a "latest" link (like @marcoscaceres seemed to want in #70 )? So we don't have to keep manually add these requests here. I'm falling behind on my open-source-promises atm so if anyone would like to check what we would need to do to make it happen, feel free to do it.

@marcoscaceres
Copy link
Contributor Author

Would be great. I don't know the folks that run the CDN... @Wilto maybe?

@Wilto
Copy link
Member

Wilto commented Apr 28, 2015

Your guess is as good as mine, honestly. We could file an issue over at https://github.com/cdnjs/cdnjs

@marcoscaceres
Copy link
Contributor Author

@Wilto, nice! thanks for the link.

@coliff
Copy link
Contributor

coliff commented Apr 28, 2015

@Wilto @marcoscaceres I saw this requested already...
cdnjs/cdnjs#360

@marcoscaceres
Copy link
Contributor Author

Ok, cool... not great that it's not possible... but at least it's on the radar and a known issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants