-
Notifications
You must be signed in to change notification settings - Fork 20
Switched to using CDN version of picturefill (closes #70) #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@seriema can you please check? Or any other lovely person:) |
@marcoscaceres I cloned it locally and checked all the demos. Seems fine, no errors that I could se. 👍 As a sidenote, I do get some things that don't load properly (like CSS on some pages) or some links not working because there seems to be a mix of how links are written. With |
Sure! that would be great! |
Switched to using CDN version of picturefill (closes #70)
Would be good to update again to Picturefill 2.3.1. :-) |
@coliff, done. |
Maybe we can get cdnjs or Picturefill to add a "latest" link (like @marcoscaceres seemed to want in #70 )? So we don't have to keep manually add these requests here. I'm falling behind on my open-source-promises atm so if anyone would like to check what we would need to do to make it happen, feel free to do it. |
Would be great. I don't know the folks that run the CDN... @Wilto maybe? |
Your guess is as good as mine, honestly. We could file an issue over at https://github.com/cdnjs/cdnjs |
@Wilto, nice! thanks for the link. |
@Wilto @marcoscaceres I saw this requested already... |
Ok, cool... not great that it's not possible... but at least it's on the radar and a known issue. |
No description provided.