Modified the relative-units use-case #33
Merged
+183
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wilto
added a commit
that referenced
this pull request
Aug 29, 2013
Modified the relative-units use-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve #32, I've modified the responsive units section.
I have not fully understood the problem up until yesterday (Thanks Marc). It is not an issue of developer convenience, but of catering for both the 1em==16px users (most of the users) and the 1em==???px users (users who have set a different default font size, or that their device did it for them).
In these cases, without em based units for art-direction, developers will have to choose between PX based MQs, resulting in text overflows, or EM based MQs, resulting in the wrong art-directed images in some cases. (possibly breaking layout or getting distorted)
We still probably need to add a figure that describes this issue.