Skip to content

Fix DecoderOptions handler. #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The current OnBeforeLoadAsync delegate is useless as DecoderOptions properties are init-only. This PR includes an emergency breaking change which updates the method to return options themselves.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #323 (6071b4e) into main (4fdc000) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #323   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        83     83           
  Lines      2371   2371           
  Branches    346    347    +1     
===================================
+ Hits       2024   2026    +2     
+ Misses      244    242    -2     
  Partials    103    103           
Flag Coverage Δ
unittests 85% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 83% <100%> (ø)
...harp.Web/Middleware/ImageSharpMiddlewareOptions.cs 93% <100%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit 67e82ab into main Apr 5, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/critical-fix-decoder-options branch April 5, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant