Skip to content

Adding docker support #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Adding docker support #352

wants to merge 3 commits into from

Conversation

Lotto
Copy link

@Lotto Lotto commented Jan 15, 2024

Adding Docker Support
Creating a Docker project to retrieve images from the /app/wwwroot folder using the ImageSharp service

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Hi @Lotto

I’m not sure what purpose this PR serves as there’s been no discussion. It looks like you’ve made unrelated changes also to the readme.

Could you please open a discussion where you explain the use case. Thanks!

@Lotto
Copy link
Author

Lotto commented Jan 16, 2024

Hello @JimBobSquarePants,

Sorry if I didn't do it right, this is my first Pull Request :)

I have been using your project for several years in my previous company. We were using .Net Framework and then .Net Core. It works perfectly in a .Net environment. Currently, I am assisting a company that is using PHP Symfony. So, I had to port your project to Docker in order to use it in an environment other than .Net and Nuget.

The purpose of this Pull Request is to have a Web project that exposes an image folder in which we can use ImageSharp.Web as in the Sample project.

I use it in Symfony projects by setting up a proxy to the public/storage/images folder to be able to resize images on the fly.

@JimBobSquarePants
Copy link
Member

Ah OK. I don’t think this belongs in this repository then. There’s too many configuration options for the middleware to be useful in enough cases.

Thanks for your efforts though!!

@sebastienros
Copy link
Contributor

@Lotto I think you have a great idea and it deserves its own repository, while ImageSharp keeps being a non-opinionated framework only. You may be clear about the license implications though since the users of you image would be subject to it. But in the end it's good for everyone, people who want to use the power of ImageSharp, and for ImageSharp by providing ready-to-use solutions based on your knowledge.

@Lotto
Copy link
Author

Lotto commented Jan 17, 2024

Okay, so if I understood correctly, I'll close the pull request and keep the fork on my account that I will maintain.

Thank you!

@Lotto Lotto closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants