Skip to content

Upgrade donation page #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 31, 2025
Merged

Upgrade donation page #712

merged 7 commits into from
May 31, 2025

Conversation

jeromehardaway
Copy link
Contributor

This pull request introduces significant updates to enhance the donation experience and improve the user interface for supporting veterans through coding education. Key changes include the addition of new components, improved layouts, and updated content to better communicate the impact of donations.

New Components and Features:

  • Added a reusable ThankYouBlock component to display a customizable thank-you message, improving acknowledgment for supporters (src/components/common/thank-you-block.tsx, src/components/common/thank-you-block.tsxR1-R18).
  • Introduced an enhanced donation form layout with detailed impact information, including where donations go, donation tiers, and contact details for assistance (src/components/forms/donate-form.tsx, src/components/forms/donate-form.tsxL10-R159).

Layout and Content Improvements:

  • Updated the DonateFormArea to include an introductory section with a mission statement, donation impact metrics, and testimonials, providing a more engaging and informative user experience (src/containers/donate-form/layout-01/index.tsx, src/containers/donate-form/layout-01/index.tsxL14-R154).

Miscellaneous:

  • Updated the apple-developer-merchantid-domain-association file with a new configuration string, likely related to Apple Pay domain association for donations (apple-developer-merchantid-domain-association, apple-developer-merchantid-domain-associationR1).

@jeromehardaway jeromehardaway requested a review from Copilot May 24, 2025 03:11
@jeromehardaway jeromehardaway self-assigned this May 24, 2025
Copy link

vercel bot commented May 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vets-who-code-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 3:16am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhances the donation page with a richer layout, new acknowledgement component, and styling tweaks to improve user engagement and readability.

  • Introduces a reusable ThankYouBlock for post-donation messaging
  • Expands the donation form area with intro text, impact metrics, and testimonials
  • Updates service-area and prework-button styling for consistent responsive layout

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/pages/donate.tsx Added ThankYouBlock, SEO description update
src/containers/service/layout-03/index.tsx Reordered and grouped Tailwind classes
src/containers/prework-button/index.tsx Adjusted class ordering in PreworkButton
src/containers/donate-form/layout-01/index.tsx Expanded DonateFormArea with intro, metrics, and testimonials
src/components/forms/donate-form.tsx Updated DonateForm layout, iframe params & styling
src/components/common/thank-you-block.tsx New reusable thank-you component
Files not reviewed (2)
  • apple-developer-merchantid-domain-association: Language not supported
  • src/data/authors/james-scott.json: Language not supported
Comments suppressed due to low confidence (3)

src/containers/prework-button/index.tsx:5

  • [nitpick] Using a <button> inside <Link> can confuse assistive tech. Consider using an <a> element styled as a button or wrapping the link around an <a> for proper semantics.
<Link href="https://github.com/Vets-Who-Code/Prework" passHref>

src/components/forms/donate-form.tsx:71

  • The iframe title is generic (#VWC Donorbox). For screen readers, use a more descriptive title like Vets Who Code Donation Form.
<iframe

src/containers/donate-form/layout-01/index.tsx:19

  • The new intro, metrics, and testimonial sections lack automated tests. Consider adding snapshot or integration tests to guard against future regressions.
{/* Intro Section */}

@jeromehardaway jeromehardaway merged commit b637958 into master May 31, 2025
3 checks passed
@jeromehardaway jeromehardaway deleted the UpgradeDonationPage branch May 31, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant