Skip to content

added more fun language #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2025
Merged

added more fun language #717

merged 2 commits into from
Jun 1, 2025

Conversation

jeromehardaway
Copy link
Contributor

This pull request updates the GamePage in src/pages/game.tsx with a rebranding of the military trivia game and a more engaging introduction. The most significant changes include renaming the game, updating the SEO metadata, and enhancing the game's description to add humor and context.

Rebranding and UI Text Updates:

  • Updated the game's title from "Military Trivia Game" to "Who's Branch Is It Anyway?" in both the SEO metadata and the page header.
  • Revised the introductory description to include a humorous and engaging narrative, emphasizing the game's theme and adding references to military culture.

Code Style Improvement:

  • Adjusted the facts mapping function to include parentheses around the arrow function parameter for consistency with coding standards.

@jeromehardaway jeromehardaway requested a review from Copilot June 1, 2025 22:45
@jeromehardaway jeromehardaway self-assigned this Jun 1, 2025
Copy link

vercel bot commented Jun 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vets-who-code-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2025 10:49pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR rebrands the trivia game, updates SEO metadata, refactors minor style, and enhances the intro with humor.

  • Renamed the game title in SEO and header from "Military Trivia Game" to "Who's Branch Is It Anyway?"
  • Expanded and humorized the introductory copy into three paragraphs
  • Applied parentheses around the arrow function parameter in the factsData.map call
Comments suppressed due to low confidence (1)

src/pages/game.tsx:225

  • New UI text blocks were added here; consider adding or updating snapshot and/or component tests to cover these changes and prevent future regressions.
<p className="tw-mb-3 tw-text-lg tw-text-secondary">

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jeromehardaway jeromehardaway merged commit aa2de2b into master Jun 1, 2025
3 checks passed
@jeromehardaway jeromehardaway deleted the CleanUpGame branch June 1, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant