Skip to content

Refactor: Replace Section component imports with EngagementModal in … #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

jeromehardaway
Copy link
Contributor

This pull request introduces debugging enhancements to the EngagementModal component and consolidates imports across multiple files to use the updated path for the Section component. The most important changes include adding debugging logs to the EngagementModal and replacing @ui/section imports with @components/ui/engagement-modal.

Debugging Enhancements to EngagementModal:

  • Added useEffect hooks to log the mount state and open state for debugging purposes in src/components/ui/engagement-modal/EngagementModal.tsx.
  • Removed the hasInitialized ref and its associated logic as it is no longer needed.

Import Path Updates:

  • Updated all instances of Section imports from @ui/section to @components/ui/engagement-modal across multiple files, including src/containers/about, src/containers/blog, src/containers/contact-form, and others. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]…various containers
  • Updated imports in blog, brand, contact, course, cta, donate, event, faq, funfact, gradation, newsletter, profile, quote, register-guide, service, team, testimonial, timeline, video, and zoom-meetings containers to use EngagementModal instead of the previous Section component.
  • Added EngagementModal component with custom animations and accessibility features.
  • Introduced EngagementModal styles for improved UI/UX.

…various containers

- Updated imports in blog, brand, contact, course, cta, donate, event, faq, funfact, gradation, newsletter, profile, quote, register-guide, service, team, testimonial, timeline, video, and zoom-meetings containers to use EngagementModal instead of the previous Section component.
- Added EngagementModal component with custom animations and accessibility features.
- Introduced EngagementModal styles for improved UI/UX.
@jeromehardaway jeromehardaway self-assigned this Jun 17, 2025
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vets-who-code-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 9:31pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the import paths for the Section component to use the EngagementModal component and introduces debugging enhancements to the EngagementModal.

  • Replaced all Section imports from "@ui/section" with "@components/ui/engagement-modal".
  • Added useEffect hooks in EngagementModal for logging mount and open state, and removed the obsolete hasInitialized ref.

Reviewed Changes

Copilot reviewed 64 out of 64 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/containers/contact-info/layout-01/index.tsx Updated import to use EngagementModal.
src/containers/contact-form/layout-02/index.tsx Updated import to use EngagementModal.
src/containers/contact-form/layout-01/index.tsx Updated import to use EngagementModal.
src/containers/brand/layout-02/index.tsx Updated import to use EngagementModal.
src/containers/brand/layout-01/index.tsx Updated import to use EngagementModal.
src/containers/blog/layout-03/index.tsx Updated import to use EngagementModal.
src/containers/blog/layout-02/index.tsx Updated import to use EngagementModal.
src/containers/blog/layout-01/index.tsx Updated import to use EngagementModal.
src/containers/blog-full/layout-05/index.tsx Updated import to use EngagementModal.
src/containers/blog-full/layout-04/index.tsx Updated import to use EngagementModal.
src/containers/blog-full/layout-03/index.tsx Updated import to use EngagementModal.
src/containers/blog-full/layout-02/index.tsx Updated import to use EngagementModal.
src/containers/blog-full/layout-01/index.tsx Updated import to use EngagementModal.
src/containers/app-download/index.tsx Updated import to use EngagementModal.
src/containers/about/layout-02/index.tsx Updated import to use EngagementModal.
src/containers/about/layout-01/index.tsx Updated import to use EngagementModal.
src/components/vwc-grid/index.tsx Updated import to use EngagementModal.
src/components/ui/engagement-modal/EngagementModal.tsx Added debugging logs and removed redundant ref.
Comments suppressed due to low confidence (1)

src/components/ui/engagement-modal/EngagementModal.tsx:34

  • Consider conditionally disabling or removing the debug logs in the EngagementModal component before deploying to production to avoid exposing internal state.
    }, []);

Copy link

🔍 Code Quality Score Breakdown:

  • 📖 Readability: 4/10
  • 📈 Scalability: 5/10
  • 🚀 Performance: 5/10
  • 🛠️ Maintainability: 8/10
  • ✅ Overall Score: 5.5/10

💡 Recommendations:

  • 🧹 Reduce ESLint warnings to improve readability.
  • 📦 Break up complex functions or components.
  • ⚙️ Consider splitting large files or lazy-loading.
  • 🔁 Refactor to increase your overall score next cycle.

@jeromehardaway jeromehardaway merged commit b56e409 into master Jun 17, 2025
5 checks passed
@jeromehardaway jeromehardaway deleted the consolidateEngagementCode branch June 17, 2025 22:24
jonulak added a commit that referenced this pull request Jun 18, 2025
commit b56e409
Author: Jerome Hardaway <jerome@vetswhocode.io>
Date:   Tue Jun 17 18:24:35 2025 -0400

     Refactor: Replace Section component imports with EngagementModal in various containers (#781)

    - Updated imports in blog, brand, contact, course, cta, donate, event, faq, funfact, gradation, newsletter, profile, quote, register-guide, service, team, testimonial, timeline, video, and zoom-meetings containers to use EngagementModal instead of the previous Section component.
    - Added EngagementModal component with custom animations and accessibility features.
    - Introduced EngagementModal styles for improved UI/UX.

commit bc3c9d2
Author: Jerome Hardaway <jerome@vetswhocode.io>
Date:   Tue Jun 17 13:22:46 2025 -0400

     refactor: remove unused EngagementModal component and associated animations

commit 8add330
Author: Jerome Hardaway <jerome@vetswhocode.io>
Date:   Tue Jun 17 08:44:42 2025 -0400

     Add Engagement Modal with custom animations and accessibility features (#780)

    - Implemented EngagementModal component with props for headline, body, and call-to-action buttons.
    - Added custom CSS animations for emoji wiggle effect on button hover.
    - Integrated Framer Motion for smooth modal transitions.
    - Included accessibility features such as focus trapping and ESC key close functionality.
    - Added session storage logic to prevent multiple modal displays in a session.
    - Provided a development-only button to test modal functionality.

commit e4c58e6
Author: Jerome Hardaway <jerome@vetswhocode.io>
Date:   Wed Jun 11 18:44:26 2025 -0400

    refactor: streamline request body validation and Slack message formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant