Closed
Description
Description:
The post-action step for this action seems to have become much slower after version 4.0.0 was released.
In the two included images, the only major difference should be the version of actions/setup-node
.
Action version:
Using actions/setup-node@v4
15 hours after 4.0.0 was released.
Platform:
- UbuntumacOSWindows
Runner type:
- HostedSelf-hosted
Tools version:
Node 18.18.2, and Yarn@4.0.0
.
Activity
TrygveUrdahl commentedon Oct 24, 2023
I noticed that my workflow files didn't specify what node version to use for this workflow through any
node-version
ornode-version-file
. By adding that, and upgrading my project to use node 20, this issue seems to go away.nikolai-laevskii commentedon Oct 24, 2023
Thank you for detailed description of the issue! We'll investigate it and come back with details.
panva commentedon Oct 25, 2023
My workflows do always specify
node-version
but the post-action is slow as well.I also have a flow log here which despite requesting lts/iron resolved
20.8.1
which isn't lts/iron. This particular setup-node use is from a reused worflow, when setup-node is used outside of a reused workflow the correct20.9.0
is resolved.bodinsamuel commentedon Oct 27, 2023
Just want to report the same thing, from 5s -> 2m15s (Node 18)
Previous: https://github.com/specfy/stack-analyser/actions/runs/6664890448/job/18113374316
With the upgrade: https://github.com/specfy/stack-analyser/actions/runs/6664871105/job/18113316689?pr=84
ledermann commentedon Oct 31, 2023
Same here in multiple projects using JS with Yarn. The
Post Setup Node.js
job slows down from a few seconds to about 2:20 minutes after upgrading to v4.It seems to me that this only happens when JS dependencies have been updated. Re-running the job (which causes a cache hit) is fast again - perhaps because the cache doesn't need to be saved.
My conclusion: Saving the cache is significantly slower with v4 than with v3.
ari-becker commentedon Nov 4, 2023
Noticing this as well because I have an aggressive
timeout-minutes: 1
on myactions/setup-node
step, which is now causing many of my builds to fail.I concur with @ledermann that the issue is somewhere in cache-saving.
With a cache hit, the post-action takes
0s
as expected:Without a cache hit, when trying to save the cache, the post-action times out:
eregon commentedon Nov 7, 2023
See ruby/setup-ruby#543 which explains a possible cause and fix.
46 remaining items