Fix incorrect timestamp usage in window function documentation #2056
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morrySnow request review |
morrySnow
reviewed
Apr 23, 2025
| @@ -51,7 +51,7 @@ Returns the same data type as the input expression. | |||
| 1. Assume we have the following stock data, with stock symbol JDR and daily closing prices: | |||
|
|
|||
| ```sql | |||
| create table stock_ticker (stock_symbol string, closing_price decimal(8,2), closing_date timestamp); | |||
| create table stock_ticker (stock_symbol string, closing_price decimal(8,2), closing_date datetime); | |||
KassieZ
added
has comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect timestamp usage in docs
Issue
Fixes #2006
Changes
Replaced timestamp with datetime in the window function docs.
Updated SQL examples to match Doris's supported data types.
Reason:
Doris does not support timestamp, and the current docs are misleading.