Skip to content

[opt](deps) add jindofs in classpath after hadoop libs (#51689) #51722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[opt](deps) add jindofs in classpath after hadoop libs (#51689) #51722

merged 1 commit into from
Jun 17, 2025
+29 −11

Conversation

morningman
Copy link
Contributor

bp #51689

@morningman
[opt](deps) add jindofs in classpath after hadoop libs (apache#51689)
Loading
Loading status checks…
62a76f6 
Related PR: apache#49903

Problem Summary:
We should add jindofs jars in CLASSPATH, but after hadoop jars.
So that we can use the right hadoop deps instead of deps from jindofs.
@morningman morningman requested a review from dataroaring as a code owner June 14, 2025 13:36
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10895/26464)
Line Coverage 31.99% (93178/291310)
Region Coverage 31.07% (48070/154719)
Branch Coverage 27.54% (24624/89404)

dataroaring
dataroaring approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c9755f5 into apache:branch-3.0 Jun 17, 2025
21 of 24 checks passed
morningman added a commit to morningman/doris that referenced this pull request Jul 1, 2025
@morningman
[opt](deps) add jindofs in classpath after hadoop libs (apache#51689) (…
Loading
Loading status checks…
9f7990b 
…apache#51722)

bp apache#51689
morningman added a commit that referenced this pull request Jul 1, 2025
@morningman
[opt](deps) add jindofs in classpath after hadoop libs (#51689) (#51722…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d89d2b9 
…) (#52589)

bp #51689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@morningman @hello-stephen @dataroaring