[feat](params-refactor) restructure parameters for FS V2 integration #51177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized catalog parameter definitions to support the new FS V2 interface. This includes updates to parameter parsing, validation, and adaptation logic.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33773 ms |
TPC-DS: Total hot run time: 185602 ms |
ClickBench: Total hot run time: 29.68 s |
morningman
reviewed
May 24, 2025
| new FileSystemCache.FileSystemCacheKey( | ||
| LocationPath.getFSIdentity(location, properties, | ||
| bindBrokerName), properties, bindBrokerName)); | ||
| bindBrokerName), properties, bindBrokerName));*/ | ||
| //fixme |
…er-refactor-params-catalog-filesystem-step-1 # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
|
run buildall |
TPC-H: Total hot run time: 33931 ms |
TPC-DS: Total hot run time: 192729 ms |
ClickBench: Total hot run time: 28.91 s |
|
run buildall |
TPC-H: Total hot run time: 33810 ms |
TPC-DS: Total hot run time: 192289 ms |
ClickBench: Total hot run time: 29.34 s |
|
run buildall |
TPC-H: Total hot run time: 34078 ms |
TPC-DS: Total hot run time: 185699 ms |
ClickBench: Total hot run time: 28.94 s |
|
run external |
|
run buildall |
TPC-H: Total hot run time: 33745 ms |
TPC-DS: Total hot run time: 192983 ms |
ClickBench: Total hot run time: 28.97 s |
|
run buildall |
CalvinKirs
changed the title
TPC-H: Total hot run time: 33738 ms |
TPC-DS: Total hot run time: 193508 ms |
ClickBench: Total hot run time: 29.47 s |
morningman
reviewed
Jun 3, 2025
| private final Configuration conf; | ||
|
|
||
| public FileSystemCacheKey(Pair<FileSystemType, String> fs, | ||
| Map<String, String> properties, |
| @@ -52,6 +53,22 @@ public static RemoteFileSystem get(String name, Map<String, String> properties) | |||
| return new BrokerFileSystem(name, properties); | |||
| } | |||
|
|
|||
| public static RemoteFileSystem get(FileSystemType fileSystemType, Map<String, String> properties, | |||
There was a problem hiding this comment.
I think in this class, we should only keep get(StorageProperties storageProperties), and remove all other get method.
| private Map<String, String> properties; | ||
|
|
||
| public FileSystemProviderImpl(ExternalMetaCacheMgr extMetaCacheMgr, String bindBrokerName, | ||
| Map<String, String> properties) { |
There was a problem hiding this comment.
Should pass StorageProperties instead of raw map
|
|
||
| private final String bindBrokerName; | ||
|
|
||
| private final Map<String, String> properties; |
There was a problem hiding this comment.
Should use StorageProperties instead of raw map
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #50238
This PR integrates the new file system (FS) with the Catalog module, continuing the previous effort where we migrated functionalities like export and backup to use the new FS implementation.
Main Changes:
Catalog Integration with New FS:
Updated the Catalog-related logic to work with the new file system abstraction, ensuring consistent usage across the system.
Code Sync from FS V1 to V2:
Migrated relevant code from FS V1 to FS V2 to maintain functional parity and ensure compatibility.
Test Enhancements:
Added unit and integration tests for the new FS usage within the Catalog to ensure correctness and stability.