Skip to content

Fix the issue of high CPU load caused by continuously creating new ConsistentHashSelector instances under high concurrency. #15497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

DustinQiao
Copy link
Contributor

What is the purpose of the change?

Fix the issue of high CPU load caused by continuously creating new ConsistentHashSelector instances under high concurrency.

issue link: #15496

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (a0b6e47) to head (c8236f6).
Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15497      +/-   ##
============================================
- Coverage     60.91%   60.88%   -0.03%     
- Complexity       12    11461   +11449     
============================================
  Files          1898     1907       +9     
  Lines         86477    86661     +184     
  Branches      12965    12987      +22     
============================================
+ Hits          52678    52765      +87     
- Misses        28358    28442      +84     
- Partials       5441     5454      +13     
Flag Coverage Δ
integration-tests-java17 33.01% <0.00%> (-0.03%) ⬇️
integration-tests-java8 33.06% <0.00%> (-0.08%) ⬇️
samples-tests-java17 31.38% <0.00%> (-0.07%) ⬇️
samples-tests-java8 29.29% <0.00%> (+0.04%) ⬆️
unit-tests 58.81% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw added the type/enhancement Everything related with code enhancement or performance label Jun 26, 2025
@zrlw zrlw merged commit c8a8946 into apache:3.3 Jun 26, 2025
29 checks passed
@DustinQiao DustinQiao deleted the enhance_consistentHashLoadbalance branch June 27, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Everything related with code enhancement or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants