-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-18834 Fix LoggingResourceTest#testSetLevelDefaultScope #18972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi maintainers, could you please approve this workflow when you have a chance? Thanks! |
Personally, I prefer to adjust the level for the testSetLevelDefaultScope. Please see my comment on the jira |
b7fd665
to
7539ec8
Compare
@@ -113,7 +113,7 @@ public void setLevelWithInvalidArgTest() { | |||
|
|||
@Test | |||
public void testSetLevelDefaultScope() { | |||
testSetLevelWorkerScope(null, true); | |||
testSetLevelWorkerScope("worker", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I fail to catch this fix. Could you please share the detail to me?
Another way is to reset the log level in |
7539ec8
to
b5697ce
Compare
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
close as duplicate to #19920 |
https://issues.apache.org/jira/browse/KAFKA-18834
Committer Checklist (excluded from commit message)