-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-7699: Anchored punctuation #19937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hermanjakobsen
wants to merge
23
commits into
apache:trunk
Choose a base branch
from
hermanjakobsen:KAFKA-7699-anchored-punctuation
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
KAFKA-7699: Anchored punctuation #19937
hermanjakobsen
wants to merge
23
commits into
apache:trunk
from
hermanjakobsen:KAFKA-7699-anchored-punctuation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would really appreciate input from @mjsax, @ableegoldman or @bbejeck as this is my first PR to the Kafka project :) |
Very good work! |
hermanjakobsen
commented
Jun 11, 2025
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
Outdated
Show resolved
Hide resolved
…of startTime + interval
14cbe41
to
627af7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Processor API interfaces for using Anchored punctuation. As described in https://cwiki.apache.org/confluence/display/KAFKA/KIP-1146%3A+Anchored+punctuation, anchored punctuations allows the users of the PAPI to set both a start time and an interval for when the punctuations should be triggered. The changes have been based on all the places where
org.apache.kafka.streams.processor.internals.ProcessorContext.schedule()
is used.The changes consist of introducing new interfaces as the punctuation time logic in the
org.apache.kafka.streams.processor.internals.PunctuationSchedule
already supports calculating a new punctuation time based on a start time and an interval.The original
schedule()
implementations have been refactored into using the newschedule()
implementation supporting thestartTime
parameter. For the original implementations, thestartTime
parameter has been sat tonull
, effectively using the "method overloading" programming technique.