Skip to content

KAFKA-7699: Anchored punctuation #19937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: trunk
Choose a base branch
from

Conversation

hermanjakobsen
Copy link

@hermanjakobsen hermanjakobsen commented Jun 9, 2025

This PR implements Processor API interfaces for using Anchored punctuation. As described in https://cwiki.apache.org/confluence/display/KAFKA/KIP-1146%3A+Anchored+punctuation, anchored punctuations allows the users of the PAPI to set both a start time and an interval for when the punctuations should be triggered. The changes have been based on all the places where org.apache.kafka.streams.processor.internals.ProcessorContext.schedule() is used.

The changes consist of introducing new interfaces as the punctuation time logic in the org.apache.kafka.streams.processor.internals.PunctuationSchedule already supports calculating a new punctuation time based on a start time and an interval.

The original schedule() implementations have been refactored into using the new schedule() implementation supporting the startTime parameter. For the original implementations, the startTime parameter has been sat to null, effectively using the "method overloading" programming technique.

@github-actions github-actions bot added triage PRs from the community streams labels Jun 9, 2025
@hermanjakobsen
Copy link
Author

hermanjakobsen commented Jun 9, 2025

Would really appreciate input from @mjsax, @ableegoldman or @bbejeck as this is my first PR to the Kafka project :)

@andhusa
Copy link

andhusa commented Jun 10, 2025

Very good work!

@hermanjakobsen hermanjakobsen changed the title KAFKA-7699: Anchored punctuation KAFKA-7699 [WIP]: Anchored punctuation Jun 10, 2025
@hermanjakobsen hermanjakobsen changed the title KAFKA-7699 [WIP]: Anchored punctuation KAFKA-7699: Anchored punctuation Jun 11, 2025
@github-actions github-actions bot removed the triage PRs from the community label Jun 12, 2025
@hermanjakobsen hermanjakobsen force-pushed the KAFKA-7699-anchored-punctuation branch from 14cbe41 to 627af7a Compare June 12, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants