Skip to content

KAFKA-19402: Typo in EventAccumulator.java #19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025

Conversation

masonyc
Copy link
Contributor

@masonyc masonyc commented Jun 12, 2025

Fix multiple typo and grammar issues in EventAccumulator.java

Reviewers: Jhen-Yung Hsu jhenyunghsu@gmail.com, Lianet Magrans
lmagrans@confluent.io

@github-actions github-actions bot added triage PRs from the community small Small PRs labels Jun 12, 2025
@masonyc masonyc changed the title KAFKA-19402 Typo in EventAccumulator.java KAFKA-19402: Typo in EventAccumulator.java Jun 12, 2025
Copy link
Collaborator

@Yunyung Yunyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.

@github-actions github-actions bot removed the triage PRs from the community label Jun 13, 2025
@masonyc
Copy link
Contributor Author

masonyc commented Jun 20, 2025

Hi @Yunyung , thanks for reviewing, can this pr be merged?

@Yunyung
Copy link
Collaborator

Yunyung commented Jun 20, 2025

Hi, this requires a committer or PMC member who has the permissions to do so.

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masonyc. Minor suggestions to improve further (since we're reviewing the java docs in this file).

Also I would suggest that for minor fixes (like these java doc typos), you can skip creating a jira next time, and just open a PR with title "MINOR:..."

Thanks for the cleanup!

masonyc and others added 2 commits June 20, 2025 20:00
…common/runtime/EventAccumulator.java

Co-authored-by: Lianet Magrans <98415067+lianetm@users.noreply.github.com>
@Yunyung
Copy link
Collaborator

Yunyung commented Jun 20, 2025

Please also fix the typo in Line177
""time and returns null of no event is available" to if

@masonyc
Copy link
Contributor Author

masonyc commented Jun 20, 2025

Please also fix the typo in Line177 ""time and returns null of no event is available" to if

Nice catch, updated

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @masonyc! LGTM.

Could you update the PR description to align? (maybe just mention that you're fixing several typos in the java docs)

@masonyc
Copy link
Contributor Author

masonyc commented Jun 20, 2025

Thanks for the updates @masonyc! LGTM.

Could you update the PR description to align? (maybe just mention that you're fixing several typos in the java docs)

Thanks @lianetm , updated the description. Any ideas on the CI error around pr linter?

@lianetm
Copy link
Member

lianetm commented Jun 20, 2025

Any ideas on the CI error around pr linter?

Yes, no worries, we need to add the list of reviewers to the PR description. I added it myself (we generate it with the committer-tools/reviewers.py script)

@lianetm lianetm merged commit d442c31 into apache:trunk Jun 20, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants