-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-19402: Typo in EventAccumulator.java #19951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM.
Hi @Yunyung , thanks for reviewing, can this pr be merged? |
Hi, this requires a committer or PMC member who has the permissions to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @masonyc. Minor suggestions to improve further (since we're reviewing the java docs in this file).
Also I would suggest that for minor fixes (like these java doc typos), you can skip creating a jira next time, and just open a PR with title "MINOR:..."
Thanks for the cleanup!
...nator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/EventAccumulator.java
Outdated
Show resolved
Hide resolved
...nator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/EventAccumulator.java
Show resolved
Hide resolved
…common/runtime/EventAccumulator.java Co-authored-by: Lianet Magrans <98415067+lianetm@users.noreply.github.com>
Please also fix the typo in Line177 |
Nice catch, updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @masonyc! LGTM.
Could you update the PR description to align? (maybe just mention that you're fixing several typos in the java docs)
Yes, no worries, we need to add the list of reviewers to the PR description. I added it myself (we generate it with the committer-tools/reviewers.py script) |
Fix multiple typo and grammar issues in EventAccumulator.java
Reviewers: Jhen-Yung Hsu jhenyunghsu@gmail.com, Lianet Magrans
lmagrans@confluent.io