MINOR: Revert initial transactional state store semantics commit #19956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
changed the title
…)" This reverts commit 571f508 needed to register state metrics on the stream thread vs. main thread.
bbejeck
force-pushed
the
MINOR_revert_transactiona_store_commit
branch
from
1d928a8 to
8bf000e
Compare
mjsax
approved these changes
Jun 23, 2025
|
merged #19956 into 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16922 and #18732 of incomplete feature.
PRs #16922 and #18732 are part of KIP-1035. In particular,
on starting a Kafka Streams instance, if it has pre-existing state, the
state stores are initialized on the main thread. Part of this
initialization registers the stateful metrics with the JMX thread-id tag
of
main. This breaks the KIP-1076 implementation where need toregister metrics with thread-id tags of
xxxStreamThread-N. This isnecessary due to the fact that the
StreamsMetricis a singleton sharedby all
StreamThreadinstances, so we need to make sure only addmetrics for the current
StreamThreadotherwise duplicate metrics areregistered. This PR reverts the changes until a fix is implemented,
allowing the individual
StreamThreads to register the metrics.Reviewers: Matthias J. Sax matthias@confluent.io