-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bluetooth SMP: added support for Legacy pairing (MITM) with passkey #16364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acassis
reviewed
May 13, 2025
Fixed all coding style checks! (though there is only 1 test failing, not sure why...) Can I get another review, please? |
@robertc2000 please the spelling error:
|
acassis
previously approved these changes
May 27, 2025
# 1: .codespellrc # /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/uorb.h:307: afte ==> after # /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/uorb.h:405: multipled ==> multiplied #/home/runner/work/nuttx/nuttx/nuttx/include/nuttx/uorb.h:416: multipled ==> multiplied #/home/runner/work/nuttx/nuttx/nuttx/include/nuttx/uorb.h:432: provies ==> provides, proves #/home/runner/work/nuttx/nuttx/nuttx/include/nuttx/uorb.h:1173: subcribers ==> subscribers #Error: Process completed with exit code 1.
xiaoxiang781216
approved these changes
May 28, 2025
acassis
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for Legacy Bluetooth Pairing with Passkey Entry, specifically enabling the NuttX device to act in a "DisplayOnly" I/O capability role. This allows the device to pair with a peer (e.g., a smartphone) that has keyboard input capabilities, achieving Man-in-the-Middle (MITM) protection (Security Level 3 - BT_SECURITY_HIGH).
Impact
conn->sec_level
.Testing
Setup
Test Cases Executed: