Skip to content

feat(viz type): Ag Grid Table Parity with Superset Table #33774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

amaannawab923
Copy link
Contributor

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jun 14, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (76d897e) to head (bbaef64).
Report is 1967 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33774       +/-   ##
===========================================
+ Coverage   60.48%   72.93%   +12.44%     
===========================================
  Files        1931      558     -1373     
  Lines       76236    40327    -35909     
  Branches     8568     4235     -4333     
===========================================
- Hits        46114    29411    -16703     
+ Misses      28017     9823    -18194     
+ Partials     2105     1093     -1012     
Flag Coverage Δ
hive 47.18% <ø> (-1.97%) ⬇️
javascript ?
mysql 71.91% <ø> (?)
postgres 71.98% <ø> (?)
presto 50.95% <ø> (-2.85%) ⬇️
python 72.89% <ø> (+9.38%) ⬆️
sqlite 71.49% <ø> (?)
unit 100.00% <ø> (+42.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants