Skip to content

feat: acts new parameter sortBy #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

feat: acts new parameter sortBy #1637

merged 3 commits into from
Jun 16, 2025

Conversation

protoss70
Copy link
Contributor

@protoss70 protoss70 commented Jun 16, 2025 •
edited
Loading

additional docs to include for the new param sortBy for the get /acts endpoint. The new param is in this PR. I will only merge this PR after the feature is deployed.

@protoss70 protoss70 requested review from B4nan and jirimoravcik and removed request for janbuchar and fnesveda June 16, 2025 11:50
@apify-service-account
Copy link

Preview for this PR was built for commit e33de2cf and is ready at https://pr-1637.preview.docs.apify.com!

@protoss70 protoss70 changed the title Feat/acts new parameter sortby feat: acts new parameter sortBy Jun 16, 2025
janbuchar
janbuchar reviewed Jun 16, 2025
View reviewed changes
@github-actions github-actions bot added the t-integrations Issues with this label are in the ownership of the integrations team. label Jun 16, 2025
@protoss70 protoss70 removed the request for review from B4nan June 16, 2025 12:35
@apify-service-account
Copy link

Preview for this PR was built for commit 0eb28aa3 and is ready at https://pr-1637.preview.docs.apify.com!

@protoss70 protoss70 requested a review from janbuchar June 16, 2025 12:48
@janbuchar janbuchar merged commit f7c6887 into master Jun 16, 2025
9 checks passed
@janbuchar janbuchar deleted the feat/acts-new-parameter-sortby branch June 16, 2025 16:13
janbuchar added a commit that referenced this pull request Jun 16, 2025
@janbuchar
Revert "feat: acts new parameter sortBy (#1637)"
7394e55 
This reverts commit f7c6887.
@janbuchar
Copy link
Contributor

Sorry @protoss70 - I got trigger happy and merged this. If it takes too long for the feature to make it to production, I can revert the change 🤦

@protoss70
Copy link
Contributor Author

Sorry @protoss70 - I got trigger happy and merged this. If it takes too long for the feature to make it to production, I can revert the change 🤦

I have already merged the feature to develop, all tests passed so I hope it will make it to production soon. But I am not sure how long it will take as it is my first PR merged 😄

@janbuchar
Copy link
Contributor

@protoss70 I say let's keep it this way, it'll be fine 😁

@B4nan
Copy link
Member

B4nan commented Jun 16, 2025

Better mark it as a draft next time so it's not tempting to merge for others :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@protoss70 protoss70

Labels
t-integrations Issues with this label are in the ownership of the integrations team.
Projects
None yet
Milestone
117th sprint - Console team
Development

Successfully merging this pull request may close these issues.
5 participants
@protoss70 @apify-service-account @janbuchar @B4nan @jirimoravcik