Fix conflicting requirements for post/info key 'accept-role' #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On merging the [request for comments PR](#23) with the addition of a new key for `post/info`--a result of the moderation protocol being created--the new key, `accept-role`, had a change in its requirements from SHOULD to be RECOMMENDED. But during the merge something went wrong, causing `accept-role` to be listed as both RECOMMENDED and MUST, while the spirit of the change was to make a recommendation. This commit remedies the conflicting requirements.
|
Makes sense to me. 👍🏻 Do you think it's worth bumping the draft version number? My own preference would be to, just to prevent any ambiguity. |
I don't mind either way! My pov: for typos that do not affect behaviour I don't think it's needed but this is kind of straddling the line, so I think your preference to do so is probably wise :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On merging the request for comments PR with the addition of a new key for
post/info—a result of the moderation protocol being created—the new key,accept-role, had a change in its requirements from SHOULD to be RECOMMENDED. But during the merge something went wrong, causingaccept-roleto be listed as both RECOMMENDED and MUST, while the spirit of the change was to make it a recommendation.This commit remedies the conflicting requirements.