Skip to content

Hubspot: add sync info to sidebar [INTEG-2773] #9963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

joaquincasal
Copy link
Collaborator

Purpose

Add sync information in the Sidebar.

Approach

  • If there are errors in synced fields, we display an error note.
  • If there are synced fields, display how long ago they were sinced.

Testing steps

  • Update the config entry with one connected field (make sure to include the updatedAt property), go to the entry and check the "Synced x time ago" appears
  • Update the config entry with one connected field that includes the "error" property and check the warning appears in the sidebar
Screenshot 2025-07-04 at 16 26 32

@joaquincasal joaquincasal requested a review from a team as a code owner July 4, 2025 20:33
Copy link
Collaborator

@FBanfi FBanfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

Left some simple comments

variant="secondary"
isFullWidth={true}
onClick={async () => sdk.dialogs.openCurrentApp(await dialogParams())}>
Sync entry fields to Hubspot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Do we need to disable this button if there is an error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess it would depend on the error. Maybe there was a sync error but creating new fields is still possible, so I think we should let this button enabled and if there's an error they'll see it when attempting to create the new fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that 🤝😁

joaquincasal and others added 2 commits July 7, 2025 11:39
Co-authored-by: Franco Banfi <62450599+FBanfi@users.noreply.github.com>
@joaquincasal joaquincasal merged commit ded219e into hubspot Jul 7, 2025
11 checks passed
@joaquincasal joaquincasal deleted the braze-integ-2773 branch July 7, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants