Deprecated NLBankAccountNumberFieldValidator and NLPhoneNumberFieldValidator.

The validators as well as the fields will be removed in the next version
of django-localflavor. Technically this breaks semver but I think it's
ok because it's a bug fix for the previous release. These should have
been deprecated along with the fields.

Author: benkonrath

docs/changelog.rst

@@ -9,6 +9,7 @@ Modifications to existing flavors:
 - Changed RUT to NIT in CONITField form field error message.
 - Fixed validation of Czech birth numbers for birth dates after 1st January 1954
   (`gh-315 <https://github.com/django/django-localflavor/issues/315>`_).
+- Deprecated `nl.validators.NLBankAccountNumberFieldValidator` and `nl.validators.NLPhoneNumberFieldValidator`.
 
 1.6   (2017-11-22)
 ------------------

localflavor/nl/validators.py

@@ -88,8 +88,17 @@ class NLPhoneNumberFieldValidator(object):
     Validation for Dutch phone numbers.
 
     .. versionadded:: 1.3
+    .. deprecated:: 1.6.1
+        Use the django-phonenumber-field_ library instead.
+
+    .. _django-phonenumber-field: https://github.com/stefanfoulis/django-phonenumber-field
     """
 
+    def __init__(self):
+        warnings.warn('NLPhoneNumberFieldValidator is deprecated in favor of the django-phonenumber-field library.',
+                      RemovedInLocalflavor20Warning)
+        super(NLPhoneNumberFieldValidator, self).__init__()
+
     def __eq__(self, other):
         # The is no outside modification of properties so this should always be true by default.
         return True
@@ -116,6 +125,10 @@ class NLBankAccountNumberFieldValidator(RegexValidator):
     http://www.credit-card.be/BankAccount/ValidationRules.htm#NL_Validation
 
     .. versionadded:: 1.1
+    .. deprecated:: 1.6.1
+        Use the django-phonenumber-field_ library instead.
+
+    .. _django-phonenumber-field: https://github.com/stefanfoulis/django-phonenumber-field
     """
 
     default_error_messages = {
@@ -124,6 +137,8 @@ class NLBankAccountNumberFieldValidator(RegexValidator):
     }
 
     def __init__(self, regex=None, message=None, code=None):
+        warnings.warn('NLBankAccountNumberFieldValidator is deprecated in favor of the django-phonenumber-field '
+                      'library.', RemovedInLocalflavor20Warning)
         super(NLBankAccountNumberFieldValidator, self).__init__(regex='^[0-9]+$',
                                                                 message=self.default_error_messages['invalid'])
         self.no_leading_zeros_regex = re.compile('[1-9]+')

tests/test_deprecated/tests.py

@@ -29,7 +29,8 @@
 from localflavor.nl.forms import NLSoFiNumberField as NLSoFiNumberFormField
 from localflavor.nl.forms import NLPhoneNumberField
 from localflavor.nl.models import NLSoFiNumberField
-from localflavor.nl.validators import NLSoFiNumberFieldValidator
+from localflavor.nl.validators import (NLBankAccountNumberFieldValidator, NLPhoneNumberFieldValidator,
+                                       NLSoFiNumberFieldValidator)
 from localflavor.no.forms import NOPhoneNumberField
 from localflavor.nz.forms import NZPhoneNumberField
 from localflavor.pk import models as pk_models
@@ -60,7 +61,7 @@ class PhoneNumberModel(Model):
             self.assertIn('deprecated::', field.__class__.__doc__)
 
     def test_PhoneNumberFormField_deprecated(self):
-        deprecated_form_fields = (
+        deprecated_classes = (
             AUPhoneNumberField,
             BEPhoneNumberField,
             BRPhoneNumberField,
@@ -82,6 +83,7 @@ def test_PhoneNumberFormField_deprecated(self):
             ITPhoneNumberField,
             LTPhoneField,
             NLPhoneNumberField,
+            NLPhoneNumberFieldValidator,
             NOPhoneNumberField,
             NZPhoneNumberField,
             PKPhoneNumberField,
@@ -95,7 +97,7 @@ def test_PhoneNumberFormField_deprecated(self):
 
         with warnings.catch_warnings(record=True) as recorded:
             warnings.simplefilter("always")
-            for form_field in deprecated_form_fields:
+            for form_field in deprecated_classes:
                 self.assertIn('deprecated::', form_field.__doc__)
                 form_field()
 
@@ -134,3 +136,9 @@ class BankAccountModel(Model):
 
         nl_bank_account_field = BankAccountModel._meta.get_field('nl_bank_account')
         self.assertIn('deprecated::', nl_bank_account_field.__class__.__doc__)
+
+        with warnings.catch_warnings(record=True) as recorded:
+            warnings.simplefilter('always')
+            NLBankAccountNumberFieldValidator()
+
+        self.assertTrue(all(w.category is RemovedInLocalflavor20Warning for w in recorded))