-
-
Notifications
You must be signed in to change notification settings - Fork 997
Added Fellow call for applicant banner. #2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/templates/base_docs.html
Outdated
@@ -10,7 +10,15 @@ | |||
{% endblock %} | |||
|
|||
{% block header %} | |||
<p><a href="{% block doc_url %}{% url 'homepage' %}{% endblock %}">{% trans 'Documentation' %}</a></p> | |||
{% comment %} | |||
<h1><a href="{% block doc_url %}{% url 'homepage' %}{% endblock %}">{% trans 'Documentation' %}</a></h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this should have been an <h1>
from the start instead of a <p>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, it should be a <p>
tag. Bad copy and paste from a previous commit 👍
1139307
to
036cbd3
Compare
This works! We do occasionally want to have this banner/CTA encouraging folks to do something (apply, donate, survey etc) so if you want to improve the design, I'm happy for you to suggest/push changes I am hoping we put this in place by the end of the week 👍 |
Hey @sarahboyce 🤗 Does it render well in dark theme? |
@sabderemane makes sense to me.
The background color doesn't change unlike the copy-banner, but renders fine apart from that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve and merge this PR given the urgency, and as mentioned in the comments, discuss a better approach for banners in a separate PR, that can be reused for later uses.
Homepage:
Documentation:
Note that we can put it in more places but I think this is a reasonable start
This idea came from @knyghty when I mentioned that blog articles can get "lost" if we have several posts