Skip to content

Added Fellow call for applicant banner. #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

sarahboyce
Copy link
Contributor

Homepage:

image

Documentation:

Screenshot from 2025-06-11 11-24-06


Note that we can put it in more places but I think this is a reasonable start
This idea came from @knyghty when I mentioned that blog articles can get "lost" if we have several posts

@sarahboyce sarahboyce requested a review from a team June 11, 2025 09:25
@@ -10,7 +10,15 @@
{% endblock %}

{% block header %}
<p><a href="{% block doc_url %}{% url 'homepage' %}{% endblock %}">{% trans 'Documentation' %}</a></p>
{% comment %}
<h1><a href="{% block doc_url %}{% url 'homepage' %}{% endblock %}">{% trans 'Documentation' %}</a></h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this should have been an <h1> from the start instead of a <p>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, it should be a <p> tag. Bad copy and paste from a previous commit 👍

@SaptakS
Copy link
Contributor

SaptakS commented Jun 11, 2025

I feel putting the call for applicant link in the same space as "Documentation" with a dash might not be the best UI (I personally feel I would be confused, since I would think that the text after dash usually would denote an internal page title).
Maybe something more like this makes sense? Thoughts?:
image

@sarahboyce
Copy link
Contributor Author

I feel putting the call for applicant link in the same space as "Documentation" with a dash might not be the best UI (I personally feel I would be confused, since I would think that the text after dash usually would denote an internal page title). Maybe something more like this makes sense? Thoughts?: image

This works!
I was copying what we have done previously for the PyCharm banner.

We do occasionally want to have this banner/CTA encouraging folks to do something (apply, donate, survey etc) so if you want to improve the design, I'm happy for you to suggest/push changes

I am hoping we put this in place by the end of the week 👍

@sabderemane
Copy link
Member

Hey @sarahboyce 🤗
I join @SaptakS 's feedback and I have few additional feedbacks but I think it might better to provide them in the issue to ease the addition of a banner for every case, so we can merge this one to have it ASAP since the announcement was quite recent and we can improve the design and code for the PR in another PR 👌🏽

Does it render well in dark theme?

@SaptakS
Copy link
Contributor

SaptakS commented Jun 11, 2025

@sabderemane makes sense to me.

Does it render well in dark theme?

The background color doesn't change unlike the copy-banner, but renders fine apart from that.

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve and merge this PR given the urgency, and as mentioned in the comments, discuss a better approach for banners in a separate PR, that can be reused for later uses.

@SaptakS SaptakS merged commit 3433db1 into django:main Jun 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants