Skip to content

Fix icon color in light/dark modes #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix icon color in light/dark modes #2107

merged 1 commit into from
Jun 23, 2025

Conversation

frankwiles
Copy link
Member

  • Icon had hard coded color for dark mode and looked all wrong (grey) in light mode.

- Icon had hard coded color for dark mode and looked all wrong (grey) in
  light mode.
@frankwiles frankwiles merged commit a214afc into main Jun 23, 2025
4 checks passed
@frankwiles frankwiles deleted the package-icon-fix branch June 23, 2025 16:58
@frankwiles
Copy link
Member Author

frankwiles commented Jun 23, 2025

Fixes #2108

@bmispelon
Copy link
Member

Thanks for the fix @frankwiles ! ✨

While it's not a big deal for this PR (the change was fairly trivial after all, though I wonder if some other icons might be impacted by a similar issue), please don't merge your own pr without a review next time (ideally from the website working group).

@frankwiles
Copy link
Member Author

Yeah I figured it was ok since it was such a small change, but noted.

This was an icon I added as part of the Package Ecosystem page and not sure if I set the color specifically in that PR or just neglected to change it to currentColor. In any case, the other icons are all set full="currentColor" already so should be zero impact to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants