Add CLI flag to override typeshed #488
Conversation
Add --typeshed-path flag to pyrefly check command for testing typeshed upgrades and custom typeshed modifications. - Add typeshed_path CLI argument to ConfigOverrideArgs - Add typeshed_path field to ConfigFile struct - Wire custom typeshed lookup into find_import() logic - Custom typeshed takes precedence over bundled typeshed - Falls back gracefully to bundled typeshed if module not found Fixes facebook#483
There was a problem hiding this comment.
Hey @krikera, thanks for doing this! Just a few things that need to be changed before we can get this in.
Once you're able to fix them, please re-request my review and I'll come check it out!
There was a problem hiding this comment.
Looks like there's still a part from the last review that is unaddressed. Let me know when it's fixed and I'll review/pull it in @krikera!
pyrefly/lib/config/config.rs
Outdated
| @@ -223,6 +223,10 @@ pub struct ConfigFile { | |||
| )] | |||
| pub fallback_search_path: Vec<PathBuf>, | |||
|
|
|||
| /// Override the bundled typeshed with a custom path. | |||
| #[serde(skip)] | |||
There was a problem hiding this comment.
Can we make this like the other serde macros above? Probably instead of regular skip, do
#[serde(
default,
skip_serializing_if = "Vec::is_empty",
)]
pyrefly/lib/config/config.rs
Outdated
| } else if let Some(path) = find_module_in_search_path(module, self.fallback_search_path.iter()) { | ||
| Ok(path) | ||
| } else if let Some(path) = find_module_in_site_package_path( | ||
| module, | ||
| self.site_package_path(), | ||
| self.use_untyped_imports, | ||
| self.ignore_missing_source, | ||
| )? { | ||
| Ok(path) | ||
| } else { | ||
| Err(FindError::import_lookup_path( | ||
| self.structured_import_lookup_path(), | ||
| module, | ||
| &self.source, | ||
| )) | ||
| } |
There was a problem hiding this comment.
Hey @krikera, it looks like this part is still duplicated here. Can you delete this before I pull it in?
It's doing the same thing as lines 388-403 as far as I can tell.
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D77937605. |
|
@yangdanny97 merged this pull request in 5e36fb7. |
|
Thanks for your contribution @krikera ! |
Add --typeshed-path flag to pyrefly check command for testing typeshed upgrades and custom typeshed modifications.
Fixes #483