Skip to content

Remove the fallback for NodeJS 14 from string.replace() #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

00-kat
Copy link
Contributor

@00-kat 00-kat commented May 20, 2025

NodeJS 14 has been EOL for a little over two years now (with the last update to it being on 2023-02-16).

According to https://nodejs.org/en/about/previous-releases, NodeJS 14
has been EOL for a little over two years (with the last update to it
being on 2023-02-16). All currently supported targets should hence have
`String.prototype.replaceAll()` present, so the fallback added in
97b12bb is now unnecessary.
@00-kat 00-kat mentioned this pull request May 20, 2025
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lpil lpil merged commit 6fe1ac7 into gleam-lang:main May 20, 2025
7 checks passed
@00-kat 00-kat deleted the remove-node-fallback branch May 20, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants