Improve list.sample docs and implementation
#837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog plz |
This makes it consistent with other "similar" functions like take and drop. The second label also makes it clearer that it might return less items than expected.
To make sure that the sample function doesn't take duplicate items from the original list
giacomocavalieri
force-pushed
the
sample-docs
branch
from
9465a40 to
bc354c7
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements here:
samplelabels to be consistent with similar stuff liketakeanddrop, this should also make it easier to see that it might not always returnnelementslist.rangeandlist.map2, but building it in one go