chore: Update envVar configuration to support custom envs #4272
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cesar Okuti <cesar.okuti@gmail.com>
|
|
|
Can you use Is this a breaking change? Can we make it non-breaking change ? |
Signed-off-by: Cesar Okuti <cesar.okuti@gmail.com>
Signed-off-by: Cesar Okuti <cesar.okuti@gmail.com>
I created other parameter to configure this env. But I think we can deprecate in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support IPv6 clusters, we need to configure the MY_POD_IP environment variable using the valueFrom structure. Therefore, I suggest changing the extraEnvs field to allow an open configuration instead of using a predefined range.
Additionally, I've included the self-profile configuration to be managed as part of this update.