Sourcery Starbot ⭐ refactored greencrab/pandas #1

SourceryAI · 2023-12-07T08:52:52Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/pandas master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI

Sourcery timed out performing refactorings.

Due to GitHub API limits, only the first 60 comments can be shown.

SourceryAI · 2023-12-07T08:52:54Z

setup.py

@@ -6,6 +6,7 @@
 BSD license. Parts are from lxml (https://github.com/lxml/lxml)
 """



Lines 42-57 refactored with the following changes:

Replace interpolated string formatting with f-string [×4] (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:54Z

setup.py

-            if hasattr(ext, 'include_dirs') and not numpy_incl in ext.include_dirs:
+            if hasattr(ext, 'include_dirs') and numpy_incl not in ext.include_dirs:


Function build_ext.build_extensions refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

SourceryAI · 2023-12-07T08:52:54Z

setup.py

-            for d in dirs:
-                if d == '__pycache__':
-                    self._clean_trees.append(pjoin(root, d))
-
+            self._clean_trees.extend(pjoin(root, d) for d in dirs if d == '__pycache__')


Function CleanCommand.initialize_options refactored with the following changes:

Replace a for append loop with list extend (for-append-to-extend)

SourceryAI · 2023-12-07T08:52:54Z

setup.py

-                cfile = pyxfile[:-3] + 'c'
-                msg = "C-source file '%s' not found." % (cfile) +\
-                    " Run 'setup.py cython' before sdist."
+                cfile = f'{pyxfile[:-3]}c'
+                msg = f"C-source file '{cfile}' not found. Run 'setup.py cython' before sdist."


Function CheckSDist.run refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:54Z

setup.py

-            repl = 'macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64'
            if tag[2] == 'macosx_10_6_intel':
+                repl = 'macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64'


Function BdistWheel.get_tag refactored with the following changes:

Move assignments closer to their usage (move-assign)

SourceryAI · 2023-12-07T08:52:55Z

versioneer.py

-    if "+" in pieces.get("closest-tag", ""):
-        return "."
-    return "+"
+    return "." if "+" in pieces.get("closest-tag", "") else "+"


Function plus_or_dot refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

SourceryAI · 2023-12-07T08:52:55Z

versioneer.py

-            if pieces["dirty"]:
-                rendered += ".dirty"
    else:
        # exception #1
        rendered = "0+untagged.%d.g%s" % (pieces["distance"],
                                          pieces["short"])
-        if pieces["dirty"]:
-            rendered += ".dirty"
+    if pieces["dirty"]:
+        rendered += ".dirty"


Function render_pep440 refactored with the following changes:

Hoist conditional out of nested conditional (hoist-if-from-if)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

SourceryAI · 2023-12-07T08:52:55Z

versioneer.py

-            rendered += "g%s" % pieces["short"]
+            rendered += f'g{pieces["short"]}'
    else:
        # exception #1
        rendered = "0.post%d" % pieces["distance"]
        if pieces["dirty"]:
            rendered += ".dev0"
-        rendered += "+g%s" % pieces["short"]
+        rendered += f'+g{pieces["short"]}'


Function render_pep440_post refactored with the following changes:

Replace interpolated string formatting with f-string [×2] (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:55Z

versioneer.py

-            if pieces["dirty"]:
-                rendered += ".dev0"
    else:
        # exception #1
        rendered = "0.post%d" % pieces["distance"]
-        if pieces["dirty"]:
-            rendered += ".dev0"
+    if pieces["dirty"]:
+        rendered += ".dev0"


Function render_pep440_old refactored with the following changes:

Hoist conditional out of nested conditional (hoist-if-from-if)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

SourceryAI · 2023-12-07T08:52:55Z

versioneer.py

-        raise ValueError("unknown style '%s'" % style)
+        raise ValueError(f"unknown style '{style}'")


Function render refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:58Z

versioneer.py

-    assert handlers, "unrecognized VCS '%s'" % cfg.VCS
+    assert handlers, f"unrecognized VCS '{cfg.VCS}'"


Function get_versions refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

Replace interpolated string formatting with f-string [×5] (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:58Z

versioneer.py

-    cmds = {}
-
    # we add "version" to both distutils and setuptools
    from distutils.core import Command

+


Function get_cmdclass refactored with the following changes:

Move assignment closer to its usage within a block [×2] (move-assign-in-block)

Replace interpolated string formatting with f-string [×7] (replace-interpolation-with-fstring)

Merge dictionary assignment with declaration [×2] (merge-dict-assign)

SourceryAI · 2023-12-07T08:52:58Z

versioneer.py

-    print(" creating %s" % cfg.versionfile_source)
+    print(f" creating {cfg.versionfile_source}")


Function do_setup refactored with the following changes:

Replace interpolated string formatting with f-string [×5] (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:52:58Z

versioneer.py

-        for line in f.readlines():
+        for line in f:


Function scan_setup_py refactored with the following changes:

Iterate over files directly rather than using readlines() (use-file-iterator)

SourceryAI · 2023-12-07T08:52:58Z

asv_bench/vbench_to_asv.py

-    output = 'class {}(object):\n'.format(bench.name)
+    output = f'class {bench.name}(object):\n'
    output += tab + 'goal_time = 0.2\n\n'

    if bench.setup:
-        indented_setup = [tab * 2 + '{}\n'.format(x) for x in bench.setup.splitlines()]
+        indented_setup = [tab * 2 + f'{x}\n' for x in bench.setup.splitlines()]
        output += tab + 'def setup(self):\n' + ''.join(indented_setup) + '\n'

    for kind in kinds:
-        output += tab + 'def {}_{}(self):\n'.format(kind, bench.name)
+        output += f'{tab}def {kind}_{bench.name}(self):\n'


Function vbench_to_asv_source refactored with the following changes:

Replace call to format with f-string [×3] (use-fstring-for-formatting)

Use f-string instead of string concatenation (use-fstring-for-concatenation)

SourceryAI · 2023-12-07T08:53:00Z

asv_bench/benchmarks/parser_vb.py

-        self.data = (self.data * 200)
+        self.data *= 200


Function read_csv_precise_converter.setup refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2023-12-07T08:53:00Z

asv_bench/benchmarks/parser_vb.py

-        self.data = (self.data * 200)
+        self.data *= 200


Function read_csv_roundtrip_converter.setup refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2023-12-07T08:53:00Z

asv_bench/benchmarks/parser_vb.py

-        self.data = (self.data * 200)
+        self.data *= 200


Function read_table_multiple_date.setup refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2023-12-07T08:53:00Z

asv_bench/benchmarks/parser_vb.py

-        self.data = (self.data * 200)
+        self.data *= 200


Function read_table_multiple_date_baseline.setup refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2023-12-07T08:53:00Z

asv_bench/benchmarks/replace.py

-        self.to_rep = dict(((i, (self.start_value + i)) for i in range(self.n)))
+        self.to_rep = {i: self.start_value + i for i in range(self.n)}


Function replace_large_dict.setup refactored with the following changes:

Replace list(), dict() or set() with comprehension (collection-builtin-to-comprehension)

SourceryAI · 2023-12-07T08:53:03Z

asv_bench/benchmarks/reshape.py

-        for iter in range(10):
+        for _ in range(10):


Function unstack_sparse_keyspace.setup refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2023-12-07T08:53:03Z

bench/alignment.py

-for i in range(100):
+for _ in range(100):


Lines 21-21 refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2023-12-07T08:53:03Z

bench/bench_groupby.py

-    ret = table.factorize(df['A'])
-    return ret
+    return table.factorize(df['A'])


Function f refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-12-07T08:53:03Z

bench/bench_groupby.py

-    ret = table.factorize(df['A'])
-    return ret
+    return table.factorize(df['A'])


Function g refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-12-07T08:53:03Z

bench/bench_join_panel.py

-        if len(panels) == 0:
+        if not panels:


Function create_panels_append refactored with the following changes:

Simplify sequence length comparison (simplify-len-comparison)

Replace interpolated string formatting with f-string [×2] (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:53:05Z

ci/ironcache/put.py

-key='KEY.%s.%s' %(os.environ.get('TRAVIS_REPO_SLUG','unk'),
-                   os.environ.get('JOB_NAME','unk'))
+key = f"KEY.{os.environ.get('TRAVIS_REPO_SLUG', 'unk')}.{os.environ.get('JOB_NAME', 'unk')}"

-key='KEY.%s.%s' %(os.environ.get('TRAVIS_REPO_SLUG','unk'),
-                   os.environ.get('JOB_NAME','unk'))
+key = f"KEY.{os.environ.get('TRAVIS_REPO_SLUG', 'unk')}.{os.environ.get('JOB_NAME', 'unk')}"
 print(key)

 if sys.version_info[0] > 2:
    key = bytes(key,encoding='utf8')

-key = sha1(key).hexdigest()[:8]+'.'
+key = f'{sha1(key).hexdigest()[:8]}.'


Lines 13-48 refactored with the following changes:

Replace interpolated string formatting with f-string [×4] (replace-interpolation-with-fstring)

Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

Remove unreachable code (remove-unreachable-code)

SourceryAI · 2023-12-07T08:53:05Z

doc/make.py

-    local_dir = doc_root + 'build/html'
-    remote_dir = '/usr/share/nginx/pandas/pandas-docs/version/%s/' % ver
+    local_dir = f'{doc_root}build/html'
+    remote_dir = f'/usr/share/nginx/pandas/pandas-docs/version/{ver}/'
    cmd = 'cd %s; rsync -avz . %s@pandas.pydata.org:%s -essh'
-    cmd = cmd % (local_dir, user, remote_dir)
+    cmd %= (local_dir, user, remote_dir)
    print(cmd)
    if os.system(cmd):
-        raise SystemExit(
-            'Upload to %s from %s failed' % (remote_dir, local_dir))
+        raise SystemExit(f'Upload to {remote_dir} from {local_dir} failed')

-    local_dir = doc_root + 'build/latex'
+    local_dir = f'{doc_root}build/latex'
    pdf_cmd = 'cd %s; scp pandas.pdf %s@pandas.pydata.org:%s'
-    pdf_cmd = pdf_cmd % (local_dir, user, remote_dir)
+    pdf_cmd %= (local_dir, user, remote_dir)
    if os.system(pdf_cmd):
-        raise SystemExit('Upload PDF to %s from %s failed' % (ver, doc_root))
+        raise SystemExit(f'Upload PDF to {ver} from {doc_root} failed')


Function upload_prev refactored with the following changes:

Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Replace interpolated string formatting with f-string [×3] (replace-interpolation-with-fstring)

Replace assignment with augmented assignment [×2] (aug-assign)

SourceryAI · 2023-12-07T08:53:05Z

doc/make.py

-    if os.system('git checkout v%s' % ver) != 1:
+    if os.system(f'git checkout v{ver}') != 1:


Function build_prev refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

SourceryAI · 2023-12-07T08:53:05Z

doc/make.py

@@ -164,7 +163,6 @@ def latex_forced():
        os.system('pdflatex -interaction=nonstopmode pandas.tex')
        raise SystemExit("You should check the file 'build/latex/pandas.pdf' for problems.")

-        os.chdir('../..')


Function latex_forced refactored with the following changes:

Remove unreachable code (remove-unreachable-code)

SourceryAI · 2023-12-07T08:53:05Z

doc/make.py

-        sendmail(step, '[ERROR] ' + msg)
+        sendmail(step, f'[ERROR] {msg}')


Function auto_dev_build refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

'Refactored by Sourcery'

1ec5aa7

SourceryAI commented Dec 7, 2023

View reviewed changes

		@@ -6,6 +6,7 @@
		BSD license. Parts are from lxml (https://github.com/lxml/lxml)
		"""

		if hasattr(ext, 'include_dirs') and not numpy_incl in ext.include_dirs:
		if hasattr(ext, 'include_dirs') and numpy_incl not in ext.include_dirs:

		raise ValueError("unknown style '%s'" % style)
		raise ValueError(f"unknown style '{style}'")

		assert handlers, "unrecognized VCS '%s'" % cfg.VCS
		assert handlers, f"unrecognized VCS '{cfg.VCS}'"

		print(" creating %s" % cfg.versionfile_source)
		print(f" creating {cfg.versionfile_source}")

		self.to_rep = dict(((i, (self.start_value + i)) for i in range(self.n)))
		self.to_rep = {i: self.start_value + i for i in range(self.n)}

		if os.system('git checkout v%s' % ver) != 1:
		if os.system(f'git checkout v{ver}') != 1:

		sendmail(step, '[ERROR] ' + msg)
		sendmail(step, f'[ERROR] {msg}')

Sourcery Starbot ⭐ refactored greencrab/pandas #1

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored greencrab/pandas #1

Uh oh!

Conversation

SourceryAI commented Dec 7, 2023

Uh oh!

SourceryAI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!