-
-
Notifications
You must be signed in to change notification settings - Fork 375
docs: Resolve Docs build warnings #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 94 94
Lines 18692 18692
=======================================
Hits 16537 16537
Misses 2155 2155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The patching likely happens after this warning. I don't think there's much we can do about it, other than checking to confirm that the patching is done correctly for all the warnings. |
I was really puzzled by these warnings. If you check these pages you will see they have broken links:
I'm not sure the first one ever worked, as it should have been So it seems these warnings are not just noise but real doc bugs. Side note, I forgot that nbsite has this feature that allows notebooks to be numbered ( |
@maximlt, these warnings could be fixed in a newer nbsite release. I have set over a dev deployment so that we can check it. Edit: Seems like they are still there. |
Yep I'm not sure how they could have been fixed by nbsite. At least for the two I checked, the links are clearly wrong and won't work in a Notebook or on the website. |
The ones you checked are different from the |
Please fix the changelog before you ask for review. Have you fixed the links @maximlt mentioned? |
closes #1421
This PR attempts to resolve most of the warnings and errors from the docs build.