fix(databricks/pyspark): unify timestamp/timestamp_ntz behavior #11142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
from
3e06c79 to
e0beb04
Compare
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
from
e0beb04 to
479f888
Compare
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
from
479f888 to
8558f8b
Compare
github-actions
bot
added
ci
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
from
39f33fa to
64c5194
Compare
github-actions
bot
added
postgres
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
2 times, most recently
from
39a1e8d to
0ead096
Compare
cpcloud
force-pushed
the
databricks-pyspark-timezones
branch
from
0ead096 to
98df77b
Compare
cpcloud
commented
Jun 2, 2025
| @@ -559,7 +559,7 @@ def _read_in_memory(source: Any, table_name: str, _conn: Backend, **kwargs: Any) | |||
|
|
|||
| @_read_in_memory.register("ibis.expr.types.Table") | |||
| def _table(source, table_name, _conn, **kwargs: Any): | |||
| _conn._add_table(table_name, source.to_polars()) | |||
| _conn._add_table(table_name, _conn.to_polars(source)) | |||
There was a problem hiding this comment.
This was a hidden use of the default backend.
cpcloud
commented
Jun 2, 2025
| @@ -525,6 +525,7 @@ def test_roundtrip_delta(backend, con, alltypes, tmp_path, monkeypatch): | |||
| ["databricks"], raises=AssertionError, reason="Only the devil knows" | |||
| ) | |||
| @pytest.mark.notyet(["athena"], raises=PyAthenaOperationalError) | |||
| @pytest.mark.xfail_version(pyspark=["pyspark<3.4"], raises=AssertionError) | |||
There was a problem hiding this comment.
This indicates the biggest behavior change here which is that timestamps in PySpark 3.3 are now always without a timezone, because that's all that was supported in that version of PySpark. PySpark >=3.4 supports timestamps with and without timezones.
|
I'm going to consider this a breaking change and merge it in for 11.0. I'll release 10.6.0 this week as the last release of the 10.x series, and I'll start to merge the breakages after that. |
cpcloud
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11137.
Closes #11062.