refactor: migrate over to pixi from magic

Author: kszucs

.github/workflows/test.yml

@@ -12,16 +12,11 @@ jobs:
     steps:
     - name: Checkout repo
       uses: actions/checkout@v2
-    - name: Install magic
-      run: |
-        curl -ssL https://magic.modular.com/6b3752cd-debc-45dd-b249-5d4941e1c18c | bash
-        echo "/home/runner/.modular/bin:$PATH" >> $GITHUB_PATH
-
+    - uses: prefix-dev/setup-pixi@v0.8.8
+      with:
+        cache: true
+        cache-write: ${{ github.event_name == 'push' && github.ref_name == 'main' }}
     - name: checks
-      run: |
-        /home/runner/.modular/bin/magic run fmt
-
+      run: pixi run fmt
     - name: tests
-      run: |
-        /home/runner/.modular/bin/magic run test
-
+      run: pixi run test

.gitignore

@@ -166,3 +166,7 @@ cython_debug/
 .pixi
 # magic environments
 .magic
+
+# pixi environments
+.pixi
+*.egg-info

firebolt/.python-version

@@ -0,0 +1 @@
+3.12

firebolt/README.md

@@ -69,4 +69,4 @@ struct ChunkedArray:
         self.chunks = chunks
         self.length = 0
         for chunk in chunks:
-            self.length += chunk[].length
+            self.length += chunk.length

firebolt/arrays/base.mojo

@@ -113,7 +113,7 @@ struct Buffer(Movable):
             self.ptr.bitcast[output]()[index] = value
 
 
-struct Bitmap(Writable):
+struct Bitmap(Movable, Writable):
     """Hold information about the null records in an array."""
 
     var buffer: Buffer

firebolt/buffers.mojo

@@ -142,7 +142,7 @@ alias LARGE_LIST_VIEW = 42
 
 
 @value
-struct Field(CollectionElement, EqualityComparable):
+struct Field(Copyable, Movable, EqualityComparable):
     var name: String
     var dtype: DataType
     var nullable: Bool
@@ -165,7 +165,7 @@ struct Field(CollectionElement, EqualityComparable):
         return not self == other
 
 
-struct DataType(CollectionElement, EqualityComparable, Stringable):
+struct DataType(Copyable, Movable, EqualityComparable, Stringable):
     var code: UInt8
     var native: DType
     var fields: List[Field]
@@ -346,7 +346,7 @@ fn struct_(*fields: Field) -> DataType:
     # but that doesn't seem to be supported
     var struct_fields = List[Field](capacity=len(fields))
     for field in fields:
-        struct_fields.append(field[])
+        struct_fields.append(field)
     return DataType(code=STRUCT, fields=struct_fields)
 
 

firebolt/dtypes.mojo

@@ -61,8 +61,8 @@ struct Schema(Movable):
         if not name:
             raise Error("Either an index or a name must be provided.")
         for field in self.fields:
-            if field[].name.as_string_slice() == name.value():
-                return field[]
+            if field.name.as_string_slice() == name.value():
+                return field
         raise Error(
             StringSlice("Field with name `{}` not found.").format(name.value())
         )

firebolt/schema.mojo

@@ -7,7 +7,7 @@ def test_schema_from_pyarrow():
     var pa = Python.import_module("pyarrow")
     var pyint = pa.field("int_field", pa.int32())
     var pystring = pa.field("string_field", pa.string())
-    var pyschema = pa.schema(PythonObject.list())
+    var pyschema = pa.schema(Python.list())
     pyschema = pyschema.append(pyint)
     pyschema = pyschema.append(pystring)
 
@@ -23,8 +23,8 @@ def test_schema_from_pyarrow():
 def test_primitive_array_from_pyarrow():
     var pa = Python.import_module("pyarrow")
     var pyarr = pa.array(
-        PythonObject.list(1, 2, 3, 4, 5),
-        mask=PythonObject.list(False, False, False, False, True),
+        Python.list(1, 2, 3, 4, 5),
+        mask=Python.list(False, False, False, False, True),
     )
 
     var c_array = CArrowArray.from_pyarrow(pyarr)
@@ -61,8 +61,8 @@ def test_binary_array_from_pyarrow():
     var pa = Python.import_module("pyarrow")
 
     var pyarr = pa.array(
-        PythonObject.list("foo", "bar", "baz"),
-        mask=PythonObject.list(False, False, True),
+        Python.list("foo", "bar", "baz"),
+        mask=Python.list(False, False, True),
     )
 
     var c_array = CArrowArray.from_pyarrow(pyarr)
@@ -97,12 +97,12 @@ def test_binary_array_from_pyarrow():
 def test_list_array_from_pyarrow():
     var pa = Python.import_module("pyarrow")
 
-    var pylist1 = PythonObject.list(1, 2, 3)
-    var pylist2 = PythonObject.list(4, 5)
-    var pylist3 = PythonObject.list(6, 7)
+    var pylist1 = Python.list(1, 2, 3)
+    var pylist2 = Python.list(4, 5)
+    var pylist3 = Python.list(6, 7)
     var pyarr = pa.array(
-        PythonObject.list(pylist1, pylist2, pylist3),
-        mask=PythonObject.list(False, True, False),
+        Python.list(pylist1, pylist2, pylist3),
+        mask=Python.list(False, True, False),
     )
 
     var c_array = CArrowArray.from_pyarrow(pyarr)

firebolt/tests/test_c_data.mojo

@@ -53,12 +53,12 @@ def test_schema_primitive_fields():
 def test_from_c_schema() -> None:
     var pa = Python.import_module("pyarrow")
     var pa_schema = pa.schema(
-        PythonObject.list(
+        Python.list(
             pa.field("field1", pa.list_(pa.int32())),
             pa.field(
                 "field2",
                 pa.`struct`(
-                    PythonObject.list(
+                    Python.list(
                         pa.field("field_a", pa.int32()),
                         pa.field("field_b", pa.float64()),
                     )