feat: ChunkedArray null methods (drop, count) #10
Conversation
|
Thanks for the PR! Going to take a look tomorrow. |
winding-lines
force-pushed
the
chunked-array-iteration
branch
2 times, most recently
from
43eb47a to
fb6f5a7
Compare
firebolt/arrays/chunked_array.mojo
Outdated
| """ | ||
|
|
||
| var dtype: DataType | ||
| var length: Int |
There was a problem hiding this comment.
We should store the null_count as well as the length.
| var buffer_start = 0 | ||
| # Process each buffer. | ||
| for buffer_index in range(len(self.buffers)): | ||
| var buffer = self.buffers[buffer_index] |
There was a problem hiding this comment.
What happens in the case of nested types? In case of List we have three buffers: validity, offsets, values.
There was a problem hiding this comment.
Hm, the individual type will have to know that. Let me see what language features we have available.
There was a problem hiding this comment.
Could we implement drop_nulls on the typed array interfaces ListArray, BinaryArray, PrimitiveArray[T]?
| fn size(self) -> Int: | ||
| return self.buffer.size | ||
|
|
||
| fn grow[I: Intable](mut self, target_length: I): | ||
| return self.buffer.grow[DType.bool](target_length) | ||
|
|
||
| @always_inline | ||
| fn bit_count(self) -> Int: |
There was a problem hiding this comment.
Are these methods covered with tests?
There was a problem hiding this comment.
Seems like partial_byte_set doesn't have a corresponding test case.
|
Looks good on principle but would be nice if we could split this into 3 PRs:
|
winding-lines
force-pushed
the
chunked-array-iteration
branch
from
fb6f5a7 to
16c1420
Compare
Implement some of the methods for null support: drop and count.