fix(dataset): remove extra Session in _update_external_knowledge_binding (#22263) #22265
+6
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Summary
Remove the redundant
Session(db.engine)
inDatasetService._update_external_knowledge_binding
.then re-attached to the global
db.session
for update.This adds an unnecessary connection/transaction and can raise
InvalidRequestError
if the row is already present in the identity-map.db.session
to query and update, ensuring the wholeupdate flow stays in one atomic transaction.
No new dependencies introduced.
Screenshots
Checklist
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) with no lint errors.