Skip to content

Addition of Service Mesh Pattern #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2021
Merged

Conversation

Shivanshu97i
Copy link
Contributor

@Shivanshu97i Shivanshu97i commented Sep 24, 2021

Signed-off-by: Shivanshu Singh singhshivanshu97@gmail.com

Description
added service mesh pattern

This PR fixes #5

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivanshu Singh <singhshivanshu97@gmail.com>
@welcome
Copy link

welcome bot commented Sep 24, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: Shivanshu Singh <singhshivanshu97@gmail.com>
@warunicorn19 warunicorn19 requested a review from debo19 September 24, 2021 14:18
@leecalcote
Copy link
Member

Thanks for this, @Shivanshu97i

@leecalcote leecalcote added the area/docs Improvements or additions to documentation label Sep 24, 2021
Signed-off-by: Shivanshu97i <singhshivanshu97@gmail.com>
Signed-off-by: Shivanshu97i <singhshivanshu97@gmail.com>
Copy link
Member

@debo19 debo19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just this minor change then we're good to go here.

Signed-off-by: Shivanshu97i <singhshivanshu97@gmail.com>
Copy link
Member

@debo19 debo19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks @Shivanshu97i

@debo19 debo19 merged commit 9c2553d into layer5io:master Sep 26, 2021
@welcome
Copy link

welcome bot commented Sep 26, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Markdown] Add Service Mesh Patterns to project list
3 participants