Skip to content

Fix missing numbers and added double quotes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

kingebere
Copy link

@kingebere kingebere commented May 31, 2022

Signed-off-by: kingebere gudoski30@gmail.com
Description

This PR fixes #14

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented May 31, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@kingebere kingebere changed the title added double quotes Signed-off-by: Dike Goodluck <gudoski30@gmail.com> added double quotes #14 May 31, 2022
@kingebere kingebere changed the title added double quotes #14 added double quotes May 31, 2022
@kingebere kingebere changed the title added double quotes Fix missing numbers and added double quotes May 31, 2022
Copy link
Member

@kayceeDev kayceeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dike,

Seemed like you didn't remember to sign-off your commits.

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin new-branch

Always remember to sign off every commit before pushing. e.g. git commit -s -m "Commit message here"

Signed-off-by: dike-goodluck-africa-prudential <106380728+dike-goodluck-africa-prudential@users.noreply.github.com>
Copy link

@YashKamboj YashKamboj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! ,Great Work @kingebere

@Nikhil-Ladha Nikhil-Ladha merged commit 6da1bed into layer5io:master Jun 2, 2022
@welcome
Copy link

welcome bot commented Jun 2, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted badges showing "0" open issues
5 participants