Update footer with social icons #9
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. |
Signed-off-by: Tothagata Bhattacharjee <tothagata.bhattacharjee@gmail.com> Signed-off-by: toth2000 <tothagata.bhattacharjee@gmail.com>
toth2000
force-pushed
the
toth2000/update_footer
branch
from
41b8d40 to
7891ebe
Compare
profile/README.md
Outdated
| <p align="center">Connect With Us</p> | ||
| <p align="center"> | ||
| <a href="https://discuss.layer5.io/"><img alt="discourse_logo" | ||
| src="..\assets\social-icons\discourse.svg"></a> |
There was a problem hiding this comment.
| src="..\assets\social-icons\discourse.svg"></a> | |
| src="https://github.com/layer5io/.github/blob/master/assets/social-icons/discourse.svg"></a> |
profile/README.md
Outdated
| src="..\assets\social-icons\discourse.svg"></a> | ||
| | ||
| <a href="mailto:community@layer5.io"><img alt="email_logo" | ||
| src="..\assets\social-icons\email.svg"></a> |
There was a problem hiding this comment.
| src="..\assets\social-icons\email.svg"></a> | |
| src="https://github.com/layer5io/.github/blob/master/assets/social-icons/email.svg"></a> |
There was a problem hiding this comment.
Can you please change all the src to call the images globally like this, otherwise the images don't seem to load on the overview page if called locally.
There was a problem hiding this comment.
@debo19 yes, I will make the suggested changes.
Signed-off-by: toth2000 <tothagata.bhattacharjee@gmail.com>
It will not be possible. But the actual gap will be less than the image that I have attached check this (as the image is from a VS Code markdown preview extension).
Yes, I will make the changes. |
|
Updated the icon's color for better visibility on dark mode.
|
Signed-off-by: toth2000 <tothagata.bhattacharjee@gmail.com>
|
Make sure to maintain aspect ration on these images. Currently, they are skewed. |
|
Looking into it. |
Signed-off-by: toth2000 <tothagata.bhattacharjee@gmail.com>
….github into toth2000/update_footer
|
Made the suggested changes and the icons now looks like this:
|
|
Thanks for your contribution to the Layer5 community! 🎉
|
|
@toth2000 you did some great work here. These footer icons really turned out well. |
Description
Added social icons to the footer.
This PR fixes #2
Notes for Reviewers
Signed commits