-
Notifications
You must be signed in to change notification settings - Fork 1
feat: insights temporal workers #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Temporal worker support and related services/configuration for the Insights platform, including new Docker setups, bash utilities, and workspace updates.
- Introduce a colored logging utility script (
scripts/utils
) for CI/development. - Add Docker Compose services for the
package-downloads-worker
andinsights-app
, plus scaffolding for a local Temporal environment. - Update workspace and builder scripts (
pnpm-workspace.yaml
,init-submodules.sh
, builder envs) to include new worker packages.
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
scripts/utils | New bash logging helpers for colored output |
scripts/services/package-downloads-worker.yaml | Compose service for package-downloads Temporal worker |
scripts/services/insights-app.yaml | Compose service for insights-app API |
scripts/services/docker/Dockerfile.package_downloads_worker.dockerignore | Misplaced Dockerfile in .dockerignore |
scripts/services/docker/Dockerfile.package_downloads_worker | Multi-stage Dockerfile for package-downloads worker |
scripts/services/docker/Dockerfile.insights_app.dockerignore | Dockerignore for insights-app build context |
scripts/services/docker/Dockerfile.insights_app | Multi-stage Dockerfile for insights-app frontend/backend |
scripts/scaffold/temporal/entrypoint.sh | Entrypoint script waiting on Temporal health |
scripts/scaffold/temporal/Dockerfile | Dockerfile for Temporal CLI container |
scripts/scaffold.yaml | Scaffold Compose stack including Postgres and Temporal |
scripts/builders/package-downloads-worker.env | Builder environment for package-downloads-worker image |
scripts/builders/insights-app.env | Builder environment for insights-app image |
pnpm-workspace.yaml | Include new worker packages in workspace |
package.json | Add lint-staged config for automatic license headers |
init-submodules.sh | Sparse-checkout setup for crowd.dev submodule |
database/flyway_migrate.sh | Script to run database migrations with Flyway |
database/Dockerfile.flyway | Custom Flyway image for migrations |
.gitmodules | Add crowd.dev submodule |
.env.dist.local | Default local environment variables |
.env.dist.composed | Default composed environment overrides |
Comments suppressed due to low confidence (2)
scripts/services/insights-app.yaml:9
- The Compose file is missing a top-level 'services:' key, so the 'insights-app' service block won’t be recognized. Wrap your service definitions under 'services:'.
insights-app:
.gitmodules:1
- The 'branch = main' line appears before the submodule block and may be ignored. It should be moved inside the '[submodule "submodules/crowd.dev"]' section or removed.
branch = main
scripts/services/docker/Dockerfile.package_downloads_worker.dockerignore
Outdated
Show resolved
Hide resolved
In general it looks ok, but I think we could improve the code organisation. I know you started by trying to mimic the structure we have on crowd.dev, but what we have there is a bit confusing and "entangled" with all the indirections between docker files, for example. So my suggestions would be to:
|
19a8bb8
to
2275564
Compare
Signed-off-by: anilb <epipav@gmail.com>
89c97f6
to
2d64686
Compare
Signed-off-by: anilb <epipav@gmail.com>
Signed-off-by: anilb <epipav@gmail.com>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: anilb <epipav@gmail.com>
…oundation/insights into feature/insights-temporal-workers
Signed-off-by: Efren Lim <elim@linuxfoundation.org> Signed-off-by: anilb <epipav@gmail.com> Signed-off-by: Gašper Grom <gasper.grom@gmail.com> Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org> Co-authored-by: anilb <epipav@gmail.com> Co-authored-by: Gašper Grom <gasper.grom@gmail.com> Co-authored-by: joanagmaia <jmaia@contractor.linuxfoundation.org>
main