Skip to content

Fixing various export issues #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 228 commits into from
Closed

Fixing various export issues #6019

wants to merge 228 commits into from

Conversation

ykuijs
Copy link
Member

@ykuijs ykuijs commented Apr 15, 2025

Pull Request (PR) description

This PR fixes various export issues

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@ykuijs
Copy link
Member Author

ykuijs commented Apr 16, 2025

Somehow this PR also contains a lot of changes of other PRs, even though those are already merged and available in the Dev branch.

@FabienTschanz
Copy link
Collaborator

@ykuijs What you can do is revert the branch to it's original commit you pushed and then do the merge again (or rebase it). You'll most likely need to force push the branch or do the changes again.

@ykuijs
Copy link
Member Author

ykuijs commented Apr 16, 2025

@FabienTschanz, I did a rebase with upstream/Dev to include all changes into my branch. So the original commit no longer is the commit I did before.....since it is now rebased on the most recent commit from Dev.

Can you review this PR? Most of the changes are yours anyways, so you already know what those changes are and can skip over them 😉

@FabienTschanz
Copy link
Collaborator

Looks good from what I can tell. I don't know about your changes, but I guess they are ok.

NikCharlebois and others added 28 commits May 21, 2025 12:42
Add -All to Get-MgServicePrincipalAppRoleAssignedTo - fixes microsoft#5824
…cyTag---Fix-for-AgeLimitForRetention

Update CHANGELOG.md
@ykuijs ykuijs closed this Jun 3, 2025
@ykuijs ykuijs mentioned this pull request Jun 3, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error exporting AADEntitlementManagementAccessPackageAssignmentPolicy when Access Reviews are not configured
8 participants