Bugfix - Fix catalog displayname being passed as argument instead of catalog id #6039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n9294651
requested review from
NikCharlebois,
ykuijs,
M365DSCApprover and
m365dscapproval
as code owners
n9294651
changed the title
|
Please update the changelog and we will merge |
NikCharlebois
requested changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR reverts #6013 and provides the correct fix.
Previously $Results.CatalogId was updated from being assigned $Catalog.Id to $Catalog.DisplayName. This caused flow-on issues where Get-MgBetaEntitlementManagementAccessPackageCatalogAccessPackageResource calls were failing due to being given the Catalog DisplayName as a parameter instead of the Catalog Id. This was catered for already when the catalog guid was assigned to a new variable but that variable wasn't used.
41649b1#diff-89344a5e420fd38276b064d760ff189ed4a83fa6c6c07db49b65cdb4fa123fdcR170
This Pull Request (PR) fixes the following issues
#4032
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).