-
Notifications
You must be signed in to change notification settings - Fork 23
Aime seq #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great overall. I left a few minor comments.
) | ||
self.evalreporting_comp.metric_config.init_args["model_output_col"] = "student_extracted_answer" | ||
|
||
component_configs.append(self.evalreporting_comp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only uses the evalreporting. Perhaps store the final result in a data_post_processing component so that all eval-related components only need to pick up results from it? See this as an example.
resume_from_dict = {} | ||
|
||
|
||
class AIME_SEQ_PIPELINE(AIME_PIPELINE): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a test for this class?
1- User config for teacher-student multi-agent scenario in AIME
2- Handling empty dataframes across the framework
3- Small AIME extractor fix to capture this format: Final Answer: [45]