-
Notifications
You must be signed in to change notification settings - Fork 43
[Power Pages][ActionsHub] Reactive Inactive Site. #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…with dynamic parameters
…on URL construction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new feature to reactivate inactive sites while updating data models and test cases to incorporate a language code property. Key changes include:
- Adding a new command and handler (reactivateSite) for site reactivation.
- Updating data models and API calls to include a languageCode property.
- Adjusting test cases and feature flags accordingly.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts | Added the reactivateSite command to handle site reactivation. |
src/common/utilities/WebsiteUtil.ts | Updated API handling to extract language code, and mapped response fields to include language information. |
Test files | Updated tests to supply languageCode in site details. |
Miscellaneous (constants, feature gates, interfaces) | Added new constants and updated models to support the languageCode property. |
Files not reviewed (2)
- package.json: Language not supported
- package.nls.json: Language not supported
Comments suppressed due to low confidence (1)
src/common/utilities/WebsiteUtil.ts:157
- [nitpick] Consider standardizing the property name from 'website_language' to 'languageCode' in the mapping function to align with the IWebsiteDetails interface and other parts of the codebase.
return { ...record, website_language: websiteLanguage };
src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts
Outdated
Show resolved
Hide resolved
src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts
Outdated
Show resolved
Hide resolved
src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts
Outdated
Show resolved
Hide resolved
…mand group and add languageCode to website data
This pull request introduces a new feature to reactivate inactive sites and includes several improvements and updates across multiple files. The most important changes include the addition of new commands and handlers, updates to data models to include language codes, and modifications to test cases to reflect these changes.
New Feature: Reactivate Inactive Sites
package.json
: Added new commandmicrosoft.powerplatform.pages.actionsHub.inactiveSite.reactivateSite
with appropriate titles and conditions. [1] [2] [3]src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts
: IntroducedreactivateSite
function to handle the reactivation of inactive sites.src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
: Registered the new command and imported the handler. [1] [2]Data Model Updates
src/client/power-pages/actions-hub/models/IWebsiteInfo.ts
: AddedlanguageCode
property toIWebsiteInfo
interface.src/common/services/Interfaces.ts
: AddedlanguageCode
property toIWebsiteDetails
interface.src/common/utilities/WebsiteUtil.ts
: Updated data fetching functions to includelanguageCode
in the returned website details. [1] [2] [3]Test Case Updates
src/client/test/Integration/power-pages/actions-hub/tree-items/ActiveGroupTreeItem.test.ts
: Updated test cases to includelanguageCode
in the site details. [1] [2] [3] [4] [5]src/client/test/Integration/power-pages/actions-hub/tree-items/EnvironmentGroupTreeItem.test.ts
: IncludedlanguageCode
in the test data for active and inactive websites.src/client/test/Integration/power-pages/actions-hub/tree-items/InactiveGroupTreeItem.test.ts
: AddedlanguageCode
to the test data for inactive websites. [1] [2]Miscellaneous Updates
src/common/constants.ts
: Added a new constantPOWERPAGES_SITE_RECORDS_CONTENT_PARSE_FAILED
.src/common/ecs-features/ecsFeatureGates.ts
: Enabled theenableActionsHub
feature by default.package.nls.json
: Added a new title for the reactivation command.