[Power Pages][Actions Hub][Code Site] Skip properties when present in powerpages.config.json #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ✨ Introduced IPowerPagesConfig and IPowerPagesConfigData interfaces for configuration structure. - 🛠️ Implemented readPowerPagesConfig function to parse the powerpages.config.json file. - 🔧 Enhanced uploadCodeSite function to utilize configuration data for building upload commands. - 📜 Added POWER_PAGES_CONFIG_FILE_NAME constant for configuration file name. -Priyanshu
- 🧪 Implement test for cancellation of compiledPath selection - 🐛 Add error handling test during code site upload - ✅ Ensure proper handling of public site visibility case sensitivity - -Priyanshu
There was a problem hiding this comment.
Pull Request Overview
Enhance the Power Pages code upload flow by using a config file to skip prompts when properties are defined, improve error handling, and add tests for cancellation and failure scenarios.
- Introduce
IPowerPagesConfig/IPowerPagesConfigDataandPOWER_PAGES_CONFIG_FILE_NAMEconstant - Add
readPowerPagesConfigandbuildUploadCodeSiteCommand, refactoruploadCodeSite - Add integration tests for compiledPath cancellation and upload errors
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/client/test/Integration/power-pages/actions-hub/ActionsHubCommandHandlers.test.ts | Tests for skipping upload when folder selection is canceled and for error paths |
| src/client/power-pages/actions-hub/models/IPowerPagesConfig.ts | New interfaces defining raw vs. parsed config structure |
| src/client/power-pages/actions-hub/Constants.ts | Added POWER_PAGES_CONFIG_FILE_NAME and POWER_PAGES_CONFIG_PARSE_FAILED event |
| src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts | Added config‐read and command‐build functions, refactored uploadCodeSite |
Comments suppressed due to low confidence (1)
src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts:33
- The implementation uses
fs,path, andUTF8_ENCODINGbut these are not imported or defined. Addimport * as fs from 'fs';,import * as path from 'path';and ensureUTF8_ENCODINGis defined or imported to prevent runtime errors.
import { IPowerPagesConfig, IPowerPagesConfigData } from './models/IPowerPagesConfig';
ashishchoudhary001
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the Power Pages code upload functionality, including improved configuration file handling, better error management, and expanded test coverage. The changes aim to make the upload process more robust and user-friendly.
Enhancements to Configuration Handling:
IPowerPagesConfig, to define the structure of the Power Pages configuration file, andIPowerPagesConfigDatato represent parsed configuration data. (src/client/power-pages/actions-hub/models/IPowerPagesConfig.ts)readPowerPagesConfigfunction to read and parse thepowerpages.config.jsonfile, ensuring proper handling of missing or invalid configurations. (src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts)POWER_PAGES_CONFIG_FILE_NAMEto standardize the configuration file name. (src/client/power-pages/actions-hub/Constants.ts)Improvements to Code Upload Process:
uploadCodeSitefunction to use a dynamic command builder (buildUploadCodeSiteCommand) based on the parsed configuration data, reducing hardcoded logic and improving flexibility. (src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts)Error Management Enhancements:
POWER_PAGES_CONFIG_PARSE_FAILED. (src/client/power-pages/actions-hub/Constants.ts)src/client/power-pages/actions-hub/ActionsHubCommandHandlers.ts)Expanded Test Coverage:
src/client/test/Integration/power-pages/actions-hub/ActionsHubCommandHandlers.test.ts)